You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/01/29 09:38:01 UTC

[PR] HDDS-12153. Rebase 1.4.x images on top of ozone-runner with JDK 11 [ozone-docker]

adoroszlai opened a new pull request, #39:
URL: https://github.com/apache/ozone-docker/pull/39

   ## What changes were proposed in this pull request?
   
   Ozone 1.4.x does not fully support JDK17: services work, but some CLI uses GSON, which does not (see HDDS-10538).  So images for 1.4.x should use Java 11.
   
   https://issues.apache.org/jira/browse/HDDS-12153
   
   ## How was this patch tested?
   
   Image built in CI:
   https://github.com/adoroszlai/ozone-docker/actions/runs/13027213850
   
   Tested in cluster started with [`docker-compose.yaml`](https://raw.githubusercontent.com/apache/ozone-docker/b2148701a20454fd41176aa6f75697c0b1f18a5b/docker-compose.yaml) from `latest` branch, slightly edited:
   
   ```diff
   -   image: ${OZONE_IMAGE:-apache/ozone}:${OZONE_IMAGE_VERSION:-1.4.1}${OZONE_IMAGE_FLAVOR:--rocky}
   +   image: ${OZONE_IMAGE:-apache/ozone}:${OZONE_IMAGE_VERSION:-1.4.1}${OZONE_IMAGE_FLAVOR:-}
   ```
   
   ```bash
   export OZONE_IMAGE=ghcr.io/adoroszlai/ozone
   export OZONE_IMAGE_VERSION=8ed8e020dc69b2c6ed53a5a31cafc2af161876e2
   docker compose up -d --scale datanode=3
   docker compose exec -T scm bash <<EOF
   ozone sh volume create /vol1
   ozone sh bucket create /vol1/bucket1
   ozone sh key put /vol1/bucket1/passwd /etc/passwd
   ozone debug chunkinfo /vol1/bucket1/passwd
   EOF
   ```
   
   ```
   {
     "KeyLocations": [
       [
         {
           "Datanode-HostName": "docker-ozone-datanode-2.docker-ozone_default",
           "Datanode-IP": "192.168.144.7",
           "Container-ID": 3,
           "Block-ID": 115816896921600003,
           "Locations": {
             "files": [
               "/data/hdds/hdds/CID-f3fe8fe6-5ae9-461c-98f6-1cc35961ebe4/current/containerDir0/3/chunks/115816896921600003.block"
             ],
             "pipelineID": "329e11c2-0519-4c42-87cf-d167719e0ec0"
           }
         },
         ...
       ]
     ]
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12153. Rebase 1.4.x images on top of ozone-runner with JDK 11 [ozone-docker]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #39:
URL: https://github.com/apache/ozone-docker/pull/39


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12153. Rebase 1.4.x images on top of ozone-runner with JDK 11 [ozone-docker]

Posted by "xichen01 (via GitHub)" <gi...@apache.org>.
xichen01 commented on code in PR #39:
URL: https://github.com/apache/ozone-docker/pull/39#discussion_r1935492604


##########
Dockerfile:
##########
@@ -14,7 +14,7 @@
 # limitations under the License.
 
 ARG OZONE_RUNNER_IMAGE=apache/ozone-runner
-FROM ${OZONE_RUNNER_IMAGE}:20241108-jdk17-1
+FROM ${OZONE_RUNNER_IMAGE}:20241212-1-jdk11

Review Comment:
   Should we use the latest jdk11 ozone-runner  "apache/ozone-runner:20241216-1-jdk11" ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12153. Rebase 1.4.x images on top of ozone-runner with JDK 11 [ozone-docker]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #39:
URL: https://github.com/apache/ozone-docker/pull/39#discussion_r1935523788


##########
Dockerfile:
##########
@@ -14,7 +14,7 @@
 # limitations under the License.
 
 ARG OZONE_RUNNER_IMAGE=apache/ozone-runner
-FROM ${OZONE_RUNNER_IMAGE}:20241108-jdk17-1
+FROM ${OZONE_RUNNER_IMAGE}:20241212-1-jdk11

Review Comment:
   The only difference is addition of rclone, which is used in new test that I don't think we want to backport.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12153. Rebase 1.4.x images on top of ozone-runner with JDK 11 [ozone-docker]

Posted by "xichen01 (via GitHub)" <gi...@apache.org>.
xichen01 commented on code in PR #39:
URL: https://github.com/apache/ozone-docker/pull/39#discussion_r1935558960


##########
Dockerfile:
##########
@@ -14,7 +14,7 @@
 # limitations under the License.
 
 ARG OZONE_RUNNER_IMAGE=apache/ozone-runner
-FROM ${OZONE_RUNNER_IMAGE}:20241108-jdk17-1
+FROM ${OZONE_RUNNER_IMAGE}:20241212-1-jdk11

Review Comment:
   OK, make sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12153. Rebase 1.4.x images on top of ozone-runner with JDK 11 [ozone-docker]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #39:
URL: https://github.com/apache/ozone-docker/pull/39#issuecomment-2624870587

   Thanks @xichen01 for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org