You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2017/09/29 18:43:33 UTC
[kudu-CR] KUDU-2159 Add metric for upserts converted to updates
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8177
Change subject: KUDU-2159 Add metric for upserts converted to updates
......................................................................
KUDU-2159 Add metric for upserts converted to updates
This adds a metric tracking the number of successful upsert operations
that were applied as updates, per tablet, counting since server start.
Change-Id: Iefdee21fbfdfd3c9c8dca4c06d635b89bcf15d72
---
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
4 files changed, 19 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/8177/1
--
To view, visit http://gerrit.cloudera.org:8080/8177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefdee21fbfdfd3c9c8dca4c06d635b89bcf15d72
Gerrit-Change-Number: 8177
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2159 Add metric for upserts converted to updates
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8177
to look at the new patch set (#2).
Change subject: KUDU-2159 Add metric for upserts converted to updates
......................................................................
KUDU-2159 Add metric for upserts converted to updates
This adds a metric tracking the number of successful upsert operations
that were applied as updates, per tablet, counting since server start.
Change-Id: Iefdee21fbfdfd3c9c8dca4c06d635b89bcf15d72
---
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
4 files changed, 19 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/8177/2
--
To view, visit http://gerrit.cloudera.org:8080/8177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iefdee21fbfdfd3c9c8dca4c06d635b89bcf15d72
Gerrit-Change-Number: 8177
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2159 Add metric for upserts converted to updates
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8177 )
Change subject: KUDU-2159 Add metric for upserts converted to updates
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefdee21fbfdfd3c9c8dca4c06d635b89bcf15d72
Gerrit-Change-Number: 8177
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 29 Sep 2017 19:14:07 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2159 Add metric for upserts converted to updates
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8177 )
Change subject: KUDU-2159 Add metric for upserts converted to updates
......................................................................
KUDU-2159 Add metric for upserts converted to updates
This adds a metric tracking the number of successful upsert operations
that were applied as updates, per tablet, counting since server start.
Change-Id: Iefdee21fbfdfd3c9c8dca4c06d635b89bcf15d72
Reviewed-on: http://gerrit.cloudera.org:8080/8177
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
4 files changed, 19 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefdee21fbfdfd3c9c8dca4c06d635b89bcf15d72
Gerrit-Change-Number: 8177
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2159 Add metric for upserts converted to updates
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8177 )
Change subject: KUDU-2159 Add metric for upserts converted to updates
......................................................................
Patch Set 2: Code-Review+2
Forwarding Todd's +2 since the test failures seemed to be unrelated Python/Jenkins flake.
--
To view, visit http://gerrit.cloudera.org:8080/8177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefdee21fbfdfd3c9c8dca4c06d635b89bcf15d72
Gerrit-Change-Number: 8177
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 02 Oct 2017 16:30:40 +0000
Gerrit-HasComments: No