[GitHub] [couchdb] tonysun83 commented on a change in pull request #3909: Fix new_edits:false and VDU function_clause

[GitBox <gi...@apache.org>]

tonysun83 commented on a change in pull request #3909:
URL: https://github.com/apache/couchdb/pull/3909#discussion_r801295805



##########
File path: src/fabric/src/fabric_doc_update.erl
##########
@@ -157,7 +163,12 @@ force_reply(Doc, [FirstReply | _] = Replies, {Health, W, Acc}) ->
                         false ->
                             CounterKey = [fabric, doc_update, mismatched_errors],
                             couch_stats:increment_counter(CounterKey),
-                            {error, W, [{Doc, FirstReply} | Acc]}
+                            case check_forbidden_msg(Replies) of
+                                {forbidden, Msg} ->
+                                    {Health, W, [{Doc, {forbidden, Msg}} | Acc]};
+                                false ->
+                                    {error, W, [{Doc, {mismatched_errors, Replies}} | Acc]}

Review comment:
       switched back to using FirstReply to make sure things don't 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org