You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by joel-hamill <gi...@git.apache.org> on 2017/09/15 00:32:50 UTC
[GitHub] kafka-site pull request #78: MINOR: Add header items
GitHub user joel-hamill opened a pull request:
https://github.com/apache/kafka-site/pull/78
MINOR: Add header items
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joel-hamill/kafka-site joel-hamill/header-nav
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka-site/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 6360f5f440d2eda97074acc87c6ba227495ca35d
Author: Joel Hamill <jo...@joel-hamill-confluent.local>
Date: 2017-09-15T00:32:25Z
MINOR: Add header items
----
---
[GitHub] kafka-site issue #78: MINOR: Add header items
Posted by dguy <gi...@git.apache.org>.
Github user dguy commented on the issue:
https://github.com/apache/kafka-site/pull/78
@joel-hamill thanks for the PR. However... these changes should be made against the Apache Kafka project - otherwise we run the risk of losing them.
---
[GitHub] kafka-site issue #78: MINOR: Add header items
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on the issue:
https://github.com/apache/kafka-site/pull/78
@dguy i don't think these files are in https://github.com/apache/kafka/tree/trunk/docs. these are changes specifically to the header/footer/nav.
---
[GitHub] kafka-site pull request #78: MINOR: Add header items
Posted by ewencp <gi...@git.apache.org>.
Github user ewencp commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/78#discussion_r139203439
--- Diff: includes/_nav.htm ---
@@ -36,7 +36,7 @@
<a class="b-nav__apache nav__item nav__sub__item" href="http://www.apache.org/security/" target="_blank">security</a>
</div>
- <a class="btn" href="/downloads">download</a>
+ <!-- <a class="btn" href="/downloads">download</a> -->
--- End diff --
is this commenting intentional? i imagine we would want to keep the big ol' download button even if we have the header? having it clearly highlighted seems important
---
[GitHub] kafka-site pull request #78: MINOR: Add header items
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill closed the pull request at:
https://github.com/apache/kafka-site/pull/78
---
[GitHub] kafka-site issue #78: MINOR: Add header items
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on the issue:
https://github.com/apache/kafka-site/pull/78
@manjuapu
---
[GitHub] kafka-site issue #78: MINOR: Add header items
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on the issue:
https://github.com/apache/kafka-site/pull/78
ping for review @guozhangwang @dguy
---
[GitHub] kafka-site issue #78: MINOR: Add header items
Posted by ewencp <gi...@git.apache.org>.
Github user ewencp commented on the issue:
https://github.com/apache/kafka-site/pull/78
@joel-hamill Something like this should work:
```
diff --git a/css/styles.css b/css/styles.css
index 1e75e91..2aa587e 100644
--- a/css/styles.css
+++ b/css/styles.css
@@ -241,6 +241,14 @@ ol.toc > li {
padding: 2rem 0 1rem;
background-color: #FFFFFF;
}
+.head th {
+ padding-left: .7rem;
+ padding-right: .7rem;
+}
+.head th.logo {
+ padding-left: 0;
+ padding-right: 4rem;
+}
.footer {
flex: 1;
position: relative;
diff --git a/includes/_top.htm b/includes/_top.htm
index 2f69803..ff07f8f 100644
--- a/includes/_top.htm
+++ b/includes/_top.htm
@@ -7,43 +7,13 @@
<div class="head">
<table>
<tr>
- <th><a href="/"><img width="325" height="97" class="logo" src="/images/logo.png"></a></th>
- <th></th>
- <th></th>
- <th></th>
- <th></th>
- <th></th>
- <th></th>
- <th></th>
- <th></th>
- <th></th>
- <th></th>
- <th></th>
- <th></th>
+ <th class="logo"><a href="/"><img width="325" height="97" class="logo" src="/images/logo.png"></a></th>
<th><a href="/quickstart">Getting Started</a></th>
- <th></th>
- <th></th>
- <th></th>
<th>|</th>
- <th></th>
- <th></th>
- <th></th>
<th><a href="/documentation">Documentation</a></th>
- <th></th>
- <th></th>
- <th></th>
<th>|</th>
- <th></th>
- <th></th>
- <th></th>
<th><a href="/downloads">Downloads</a></th>
- <th></th>
- <th></th>
- <th></th>
<th>|</th>
- <th></th>
- <th></th>
- <th></th>
<th><a href="/events">Community</a></th>
</tr>
</table>
```
Would just push it, but don't have write access to your copy of the repo. Complete updated version is here https://github.com/ewencp/kafka-site/tree/joel-hamill/header-nav
---
[GitHub] kafka-site pull request #78: MINOR: Add header items
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/78#discussion_r139205416
--- Diff: includes/_top.htm ---
@@ -1,5 +1,55 @@
<body>
<div class="main">
- <div class="header">
+ <!-- <div class="header">
<a href="/"><img width="325" height="97" class="logo" src="/images/logo.png"></a>
+
+ </div> -->
+ <div class="head">
+ <table>
+ <tr>
+ <th><a href="/"><img width="325" height="97" class="logo" src="/images/logo.png"></a></th>
+ <th></th>
--- End diff --
it's definitely for spacing, and could definitely be handled with CSS more elegantly - however, that's outside of my level of knowledge. i was just trying to hack something together quickly. CC: @rajinisivaram
---
[GitHub] kafka-site pull request #78: MINOR: Add header items
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/78#discussion_r139205053
--- Diff: includes/_nav.htm ---
@@ -36,7 +36,7 @@
<a class="b-nav__apache nav__item nav__sub__item" href="http://www.apache.org/security/" target="_blank">security</a>
</div>
- <a class="btn" href="/downloads">download</a>
+ <!-- <a class="btn" href="/downloads">download</a> -->
--- End diff --
yeah, it was intentional. i was trying to clean up the page since IMHO there are way too many headings on the left-hand nav. but i can see how removing this might be too much. i was using this page for inspiration (which does have a big ol' icon, but is definitely better design): http://mesos.apache.org/
---
[GitHub] kafka-site pull request #78: MINOR: Add header items
Posted by ewencp <gi...@git.apache.org>.
Github user ewencp commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/78#discussion_r139203750
--- Diff: includes/_top.htm ---
@@ -1,5 +1,55 @@
<body>
<div class="main">
- <div class="header">
+ <!-- <div class="header">
<a href="/"><img width="325" height="97" class="logo" src="/images/logo.png"></a>
+
+ </div> -->
+ <div class="head">
+ <table>
+ <tr>
+ <th><a href="/"><img width="325" height="97" class="logo" src="/images/logo.png"></a></th>
+ <th></th>
--- End diff --
what's with all the empty headers? is this just for spacing or something? can we use css instead?
---
[GitHub] kafka-site issue #78: MINOR: Add header items
Posted by derrickdoo <gi...@git.apache.org>.
Github user derrickdoo commented on the issue:
https://github.com/apache/kafka-site/pull/78
@joel-hamill I'm concerned that the horizontal nav you're introducing here is going to cause some usability issues and actually conflicts with some work that's been going on with the Streams landing page.
Let's hold off on merging this until we get a chance to sync up.
---
[GitHub] kafka-site pull request #78: MINOR: Add header items
Posted by joel-hamill <gi...@git.apache.org>.
Github user joel-hamill commented on a diff in the pull request:
https://github.com/apache/kafka-site/pull/78#discussion_r139205540
--- Diff: includes/_top.htm ---
@@ -1,5 +1,55 @@
<body>
<div class="main">
- <div class="header">
+ <!-- <div class="header">
<a href="/"><img width="325" height="97" class="logo" src="/images/logo.png"></a>
+
+ </div> -->
+ <div class="head">
+ <table>
+ <tr>
+ <th><a href="/"><img width="325" height="97" class="logo" src="/images/logo.png"></a></th>
+ <th></th>
--- End diff --
---