[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3364: add journalCbQueueLatency

[GitBox <gi...@apache.org>]

hangc0276 commented on code in PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#discussion_r906748686


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/stats/JournalStats.java:
##########
@@ -153,6 +154,13 @@ public class JournalStats {
         help = "The journal callback queue size"
     )
     private final Counter journalCbQueueSize;
+
+    @StatsDoc(
+            name = JOURNAL_CB_QUEUE_LATENCY,
+            help = "The journal callback queue size"

Review Comment:
   `The journal callback queued latency` ?



##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:
##########
@@ -1118,6 +1129,7 @@ journalFormatVersionToWrite, getBufferedChannelBuilder(),
                                 if (entry != null && (!syncData || entry.ackBeforeSync)) {
                                     toFlush.set(i, null);
                                     numEntriesToFlush--;
+                                    entry.setEnqueueCbThreadPooleQueueTime(MathUtils.nowInNano());

Review Comment:
   It only records the ack without flush items, we should also record the flushed items when `syncData = true`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org