You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Jing Zhao (JIRA)" <ji...@apache.org> on 2012/10/20 00:24:12 UTC
[jira] [Created] (HDFS-4093) In branch-1-win,
AzureBlockPlacementPolicy#chooseTarget only returns one DN when replication
factor is greater than 3.
Jing Zhao created HDFS-4093:
-------------------------------
Summary: In branch-1-win, AzureBlockPlacementPolicy#chooseTarget only returns one DN when replication factor is greater than 3.
Key: HDFS-4093
URL: https://issues.apache.org/jira/browse/HDFS-4093
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Jing Zhao
Assignee: Jing Zhao
In branch-1-win, when AzureBlockPlacementPolicy (which extends the BlockPlacementPolicyDefault) is used, if the client increases the number of replicas (e.g., from 3 to 10), AzureBlockPlacementPolicy#chooseTarget will return only 1 Datanode each time. Thus in FSNameSystem#computeReplicationWorkForBlock, it is possible that the replication monitor may choose a datanode that has been chosen as target but still in the pendingReplications (because computeReplicationWorkForBlock does not check the pending replication before doing the chooseTarget).
To avoid this "hit-the-same-datanode" scenario, we modify the AzureBlockPlacementPolicy#chooseTarget to make it return multiple DN.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4093) In branch-1-win,
AzureBlockPlacementPolicy#chooseTarget only returns one DN when replication
factor is greater than 3.
Posted by "Jing Zhao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jing Zhao updated HDFS-4093:
----------------------------
Attachment: HDFS-b1-win-4093.002.patch
Updated the patch. Have passed local testcases.
> In branch-1-win, AzureBlockPlacementPolicy#chooseTarget only returns one DN when replication factor is greater than 3.
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4093
> URL: https://issues.apache.org/jira/browse/HDFS-4093
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-b1-win-4093.001.patch, HDFS-b1-win-4093.002.patch
>
>
> In branch-1-win, when AzureBlockPlacementPolicy (which extends the BlockPlacementPolicyDefault) is used, if the client increases the number of replicas (e.g., from 3 to 10), AzureBlockPlacementPolicy#chooseTarget will return only 1 Datanode each time. Thus in FSNameSystem#computeReplicationWorkForBlock, it is possible that the replication monitor may choose a datanode that has been chosen as target but still in the pendingReplications (because computeReplicationWorkForBlock does not check the pending replication before doing the chooseTarget).
> To avoid this "hit-the-same-datanode" scenario, we modify the AzureBlockPlacementPolicy#chooseTarget to make it return multiple DN.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4093) In branch-1-win,
AzureBlockPlacementPolicy#chooseTarget only returns one DN when replication
factor is greater than 3.
Posted by "Jing Zhao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jing Zhao updated HDFS-4093:
----------------------------
Attachment: HDFS-b1-win-4093.001.patch
Patch uploaded.
> In branch-1-win, AzureBlockPlacementPolicy#chooseTarget only returns one DN when replication factor is greater than 3.
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4093
> URL: https://issues.apache.org/jira/browse/HDFS-4093
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-b1-win-4093.001.patch
>
>
> In branch-1-win, when AzureBlockPlacementPolicy (which extends the BlockPlacementPolicyDefault) is used, if the client increases the number of replicas (e.g., from 3 to 10), AzureBlockPlacementPolicy#chooseTarget will return only 1 Datanode each time. Thus in FSNameSystem#computeReplicationWorkForBlock, it is possible that the replication monitor may choose a datanode that has been chosen as target but still in the pendingReplications (because computeReplicationWorkForBlock does not check the pending replication before doing the chooseTarget).
> To avoid this "hit-the-same-datanode" scenario, we modify the AzureBlockPlacementPolicy#chooseTarget to make it return multiple DN.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-4093) In branch-1-win,
AzureBlockPlacementPolicy#chooseTarget only returns one DN when replication
factor is greater than 3.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HDFS-4093.
------------------------------------------
Resolution: Fixed
Fix Version/s: 1-win
I have committed this. Thanks, Jing!
> In branch-1-win, AzureBlockPlacementPolicy#chooseTarget only returns one DN when replication factor is greater than 3.
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4093
> URL: https://issues.apache.org/jira/browse/HDFS-4093
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Fix For: 1-win
>
> Attachments: HDFS-b1-win-4093.001.patch, HDFS-b1-win-4093.002.patch
>
>
> In branch-1-win, when AzureBlockPlacementPolicy (which extends the BlockPlacementPolicyDefault) is used, if the client increases the number of replicas (e.g., from 3 to 10), AzureBlockPlacementPolicy#chooseTarget will return only 1 Datanode each time. Thus in FSNameSystem#computeReplicationWorkForBlock, it is possible that the replication monitor may choose a datanode that has been chosen as target but still in the pendingReplications (because computeReplicationWorkForBlock does not check the pending replication before doing the chooseTarget).
> To avoid this "hit-the-same-datanode" scenario, we modify the AzureBlockPlacementPolicy#chooseTarget to make it return multiple DN.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4093) In branch-1-win,
AzureBlockPlacementPolicy#chooseTarget only returns one DN when replication
factor is greater than 3.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-4093:
-----------------------------------------
Hadoop Flags: Reviewed
+1 patch looks good.
> In branch-1-win, AzureBlockPlacementPolicy#chooseTarget only returns one DN when replication factor is greater than 3.
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4093
> URL: https://issues.apache.org/jira/browse/HDFS-4093
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-b1-win-4093.001.patch, HDFS-b1-win-4093.002.patch
>
>
> In branch-1-win, when AzureBlockPlacementPolicy (which extends the BlockPlacementPolicyDefault) is used, if the client increases the number of replicas (e.g., from 3 to 10), AzureBlockPlacementPolicy#chooseTarget will return only 1 Datanode each time. Thus in FSNameSystem#computeReplicationWorkForBlock, it is possible that the replication monitor may choose a datanode that has been chosen as target but still in the pendingReplications (because computeReplicationWorkForBlock does not check the pending replication before doing the chooseTarget).
> To avoid this "hit-the-same-datanode" scenario, we modify the AzureBlockPlacementPolicy#chooseTarget to make it return multiple DN.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira