You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2013/05/08 02:59:15 UTC

Review Request: Default values for HBase and AsyncHBase default serializers

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10989/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Default HBase and AsyncHBase simple serializers required the user to provide payload column and increment column. Created default values for these for better usability. The default values are: payloadcolumn = "pCol" and increment column = "iCol". Made a note of this in the flume user doc as well. 


This addresses bug FLUME-1757.
    https://issues.apache.org/jira/browse/FLUME-1757


Diffs
-----

  flume-ng-doc/sphinx/FlumeUserGuide.rst 38f2205 
  flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/SimpleAsyncHbaseEventSerializer.java dd19616 
  flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/SimpleHbaseEventSerializer.java 52bc84d 
  flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java 03c3e4c 
  flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSink.java ad94fc9 

Diff: https://reviews.apache.org/r/10989/diff/


Testing
-------

Wrote unit tests. And validated the change. 


Thanks,

Sravya Tirukkovalur


Re: Review Request 10989: Default values for HBase and AsyncHBase default serializers

Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10989/#review23342
-----------------------------------------------------------

Ship it!


FTR, already committed

- Alexander Alten-Lorenz


On May 8, 2013, 12:59 a.m., Sravya Tirukkovalur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10989/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 12:59 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-1757
>     https://issues.apache.org/jira/browse/FLUME-1757
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Default HBase and AsyncHBase simple serializers required the user to provide payload column and increment column. Created default values for these for better usability. The default values are: payloadcolumn = "pCol" and increment column = "iCol". Made a note of this in the flume user doc as well. 
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 38f2205 
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/SimpleAsyncHbaseEventSerializer.java dd19616 
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/SimpleHbaseEventSerializer.java 52bc84d 
>   flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java 03c3e4c 
>   flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSink.java ad94fc9 
> 
> Diff: https://reviews.apache.org/r/10989/diff/
> 
> 
> Testing
> -------
> 
> Wrote unit tests. And validated the change. 
> 
> 
> Thanks,
> 
> Sravya Tirukkovalur
> 
>