[GitHub] [commons-imaging] kinow commented on pull request #156: Bump spotbugs from 4.2.3 to 4.3.0

[GitBox <gi...@apache.org>]

kinow commented on pull request #156:
URL: https://github.com/apache/commons-imaging/pull/156#issuecomment-873261776


   Ah, some new errors found by CI. Will have to fix those when merging.
   
   ```
   Error:  Medium: new org.apache.commons.imaging.ImageInfo(String, int, List, ImageFormat, String, int, String, int, int, float, int, float, int, boolean, boolean, boolean, ImageInfo$ColorType, ImageInfo$CompressionAlgorithm) may expose internal representation by storing an externally mutable object into ImageInfo.comments [org.apache.commons.imaging.ImageInfo] At ImageInfo.java:[line 117] EI_EXPOSE_REP2
   Error:  Medium: new org.apache.commons.imaging.common.BinaryOutputStream(OutputStream) may expose internal representation by storing an externally mutable object into BinaryOutputStream.os [org.apache.commons.imaging.common.BinaryOutputStream] At BinaryOutputStream.java:[line 35] EI_EXPOSE_REP2
   Error:  Medium: new org.apache.commons.imaging.common.BinaryOutputStream(OutputStream, ByteOrder) may expose internal representation by storing an externally mutable object into BinaryOutputStream.os [org.apache.commons.imaging.common.BinaryOutputStream] At BinaryOutputStream.java:[line 31] EI_EXPOSE_REP2
   Error:  Medium: new org.apache.commons.imaging.common.mylzw.BitsToByteInputStream(MyBitInputStream, int) may expose internal representation by storing an externally mutable object into BitsToByteInputStream.is [org.apache.commons.imaging.common.mylzw.BitsToByteInputStream] At BitsToByteInputStream.java:[line 27] EI_EXPOSE_REP2
   Error:  Medium: new org.apache.commons.imaging.common.mylzw.MyBitOutputStream(OutputStream, ByteOrder) may expose internal representation by storing an externally mutable object into MyBitOutputStream.os [org.apache.commons.imaging.common.mylzw.MyBitOutputStream] At MyBitOutputStream.java:[line 32] EI_EXPOSE_REP2
   Error:  Medium: new org.apache.commons.imaging.common.mylzw.MyLzwCompressor(int, ByteOrder, boolean, MyLzwCompressor$Listener) may expose internal representation by storing an externally mutable object into MyLzwCompressor.listener [org.apache.commons.imaging.common.mylzw.MyLzwCompressor] At MyLzwCompressor.java:[line 44] EI_EXPOSE_REP2
   Error:  Medium: org.apache.commons.imaging.formats.gif.GifImageMetadata.getItems() may expose internal representation by returning GifImageMetadata.items [org.apache.commons.imaging.formats.gif.GifImageMetadata] At GifImageMetadata.java:[line 63] EI_EXPOSE_REP
   Error:  Medium: org.apache.commons.imaging.formats.jpeg.JpegImageMetadata.getExif() may expose internal representation by returning JpegImageMetadata.exif [org.apache.commons.imaging.formats.jpeg.JpegImageMetadata] At JpegImageMetadata.java:[line 51] EI_EXPOSE_REP
   Error:  Medium: org.apache.commons.imaging.formats.jpeg.JpegImageMetadata.getPhotoshop() may expose internal representation by returning JpegImageMetadata.photoshop [org.apache.commons.imaging.formats.jpeg.JpegImageMetadata] At JpegImageMetadata.java:[line 55] EI_EXPOSE_REP
   Error:  Medium: new org.apache.commons.imaging.formats.jpeg.JpegImageMetadata(JpegPhotoshopMetadata, TiffImageMetadata) may expose internal representation by storing an externally mutable object into JpegImageMetadata.exif [org.apache.commons.imaging.formats.jpeg.JpegImageMetadata] At JpegImageMetadata.java:[line 47] EI_EXPOSE_REP2
   Error:  Medium: new org.apache.commons.imaging.formats.jpeg.JpegImageMetadata(JpegPhotoshopMetadata, TiffImageMetadata) may expose internal representation by storing an externally mutable object into JpegImageMetadata.photoshop [org.apache.commons.imaging.formats.jpeg.JpegImageMetadata] At JpegImageMetadata.java:[line 46] EI_EXPOSE_REP2
   Error:  Medium: org.apache.commons.imaging.formats.jpeg.decoder.JpegDecoder.decode(ByteSource) may expose internal representation by returning JpegDecoder.image [org.apache.commons.imaging.formats.jpeg.decoder.JpegDecoder] At JpegDecoder.java:[line 553] EI_EXPOSE_REP
   Error:  Medium: new org.apache.commons.imaging.formats.jpeg.iptc.PhotoshopApp13Data(List, List) may expose internal representation by storing an externally mutable object into PhotoshopApp13Data.rawBlocks [org.apache.commons.imaging.formats.jpeg.iptc.PhotoshopApp13Data] At PhotoshopApp13Data.java:[line 29] EI_EXPOSE_REP2
   Error:  Medium: new org.apache.commons.imaging.formats.jpeg.iptc.PhotoshopApp13Data(List, List) may expose internal representation by storing an externally mutable object into PhotoshopApp13Data.records [org.apache.commons.imaging.formats.jpeg.iptc.PhotoshopApp13Data] At PhotoshopApp13Data.java:[line 30] EI_EXPOSE_REP2
   Error:  Medium: org.apache.commons.imaging.formats.tiff.TiffField.getFieldType() may expose internal representation by returning TiffField.fieldType [org.apache.commons.imaging.formats.tiff.TiffField] At TiffField.java:[line 91] EI_EXPOSE_REP
   Error:  Medium: new org.apache.commons.imaging.formats.tiff.TiffImageMetadata$Directory(ByteOrder, TiffDirectory) may expose internal representation by storing an externally mutable object into TiffImageMetadata$Directory.directory [org.apache.commons.imaging.formats.tiff.TiffImageMetadata$Directory] At TiffImageMetadata.java:[line 69] EI_EXPOSE_REP2
   Error:  Medium: org.apache.commons.imaging.formats.tiff.write.TiffOutputDirectory.setNextDirectory(TiffOutputDirectory) may expose internal representation by storing an externally mutable object into TiffOutputDirectory.nextDirectory [org.apache.commons.imaging.formats.tiff.write.TiffOutputDirectory] At TiffOutputDirectory.java:[line 82] EI_EXPOSE_REP2
   Error:  Medium: new org.apache.commons.imaging.palette.QuantizedPalette(List, int) may expose internal representation by storing an externally mutable object into QuantizedPalette.subsets [org.apache.commons.imaging.palette.QuantizedPalette] At QuantizedPalette.java:[line 29] EI_EXPOSE_REP2
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org