You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Lchangliang (via GitHub)" <gi...@apache.org> on 2024/03/29 09:18:02 UTC
[PR] [BugFix] Fix rename error because the new dir exists [doris]
Lchangliang opened a new pull request, #33042:
URL: https://github.com/apache/doris/pull/33042
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33042:
URL: https://github.com/apache/doris/pull/33042#issuecomment-2027032311
<details>
<summary>TPC-DS: <b>Total hot run time: 181949 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3dee516290e0609fa7bbbb507cf45fdf88cc82ee, data reload: false
query1 883 1122 349 349
query2 7166 2069 1897 1897
query3 6671 217 219 217
query4 22798 21367 21313 21313
query5 4229 407 382 382
query6 295 197 179 179
query7 4585 300 292 292
query8 216 169 171 169
query9 8355 2304 2288 2288
query10 400 239 236 236
query11 15007 14369 14277 14277
query12 132 91 87 87
query13 1628 368 379 368
query14 9016 7088 7175 7088
query15 221 173 182 173
query16 6993 275 275 275
query17 1376 602 559 559
query18 1828 295 296 295
query19 202 158 157 157
query20 92 85 86 85
query21 202 137 138 137
query22 4992 4809 4840 4809
query23 33335 32479 32757 32479
query24 12627 2880 2859 2859
query25 702 422 433 422
query26 1815 164 162 162
query27 3444 372 381 372
query28 7961 1958 1933 1933
query29 1112 643 643 643
query30 293 158 156 156
query31 1004 743 758 743
query32 95 54 55 54
query33 752 237 251 237
query34 1326 517 499 499
query35 894 734 703 703
query36 1079 946 950 946
query37 222 79 71 71
query38 3820 3643 3673 3643
query39 1643 1583 1590 1583
query40 249 130 138 130
query41 52 47 48 47
query42 118 105 100 100
query43 498 483 477 477
query44 1274 760 768 760
query45 288 281 264 264
query46 1138 728 706 706
query47 2058 1974 1999 1974
query48 426 324 318 318
query49 946 380 396 380
query50 820 423 403 403
query51 7027 6937 6896 6896
query52 109 95 95 95
query53 346 275 286 275
query54 304 227 232 227
query55 88 84 78 78
query56 249 222 234 222
query57 1312 1174 1255 1174
query58 235 210 225 210
query59 3034 2758 2801 2758
query60 254 249 237 237
query61 95 89 91 89
query62 589 440 427 427
query63 305 271 274 271
query64 6476 4178 3940 3940
query65 3066 3017 3050 3017
query66 1349 331 328 328
query67 15549 15264 14711 14711
query68 9895 550 556 550
query69 594 313 307 307
query70 1371 1106 1146 1106
query71 563 268 263 263
query72 7049 2618 2457 2457
query73 1611 331 330 330
query74 6862 6303 6320 6303
query75 4395 2244 2254 2244
query76 5446 981 1102 981
query77 580 251 240 240
query78 10865 10337 10085 10085
query79 11328 517 531 517
query80 1728 438 414 414
query81 537 1068 211 211
query82 252 85 90 85
query83 201 166 159 159
query84 248 82 81 81
query85 932 267 258 258
query86 331 286 293 286
query87 3777 3556 3537 3537
query88 5690 2473 2426 2426
query89 499 365 374 365
query90 2072 177 178 177
query91 126 94 96 94
query92 63 45 45 45
query93 6656 498 507 498
query94 1348 182 179 179
query95 409 317 305 305
query96 606 269 277 269
query97 2629 2500 2470 2470
query98 232 223 212 212
query99 1081 878 844 844
Total cold run time: 307641 ms
Total hot run time: 181949 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33042:
URL: https://github.com/apache/doris/pull/33042#issuecomment-2027018540
<details>
<summary>TPC-H: <b>Total hot run time: 38256 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3dee516290e0609fa7bbbb507cf45fdf88cc82ee, data reload: false
------ Round 1 ----------------------------------
q1 18093 4657 4213 4213
q2 2087 192 187 187
q3 10544 1088 1147 1088
q4 10225 754 725 725
q5 7469 2852 2705 2705
q6 212 128 132 128
q7 1038 611 595 595
q8 9220 2039 2035 2035
q9 7435 6596 6505 6505
q10 8471 3476 3529 3476
q11 482 242 249 242
q12 404 235 214 214
q13 17785 3011 2971 2971
q14 271 229 238 229
q15 531 471 466 466
q16 553 390 384 384
q17 963 565 665 565
q18 7402 6861 6734 6734
q19 7474 1438 1434 1434
q20 689 305 304 304
q21 3478 2747 2848 2747
q22 363 313 309 309
Total cold run time: 115189 ms
Total hot run time: 38256 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4302 4241 4128 4128
q2 383 269 261 261
q3 2942 2742 2668 2668
q4 1871 1516 1503 1503
q5 5309 5223 5173 5173
q6 212 126 130 126
q7 2187 1855 1872 1855
q8 3198 3327 3289 3289
q9 8605 8615 8573 8573
q10 4074 3803 3885 3803
q11 652 493 507 493
q12 761 610 605 605
q13 17678 3255 3187 3187
q14 310 287 293 287
q15 524 477 476 476
q16 499 461 449 449
q17 1848 1468 1476 1468
q18 8032 7964 7863 7863
q19 1627 1534 1541 1534
q20 2061 1840 1826 1826
q21 5232 4847 5010 4847
q22 539 489 478 478
Total cold run time: 72846 ms
Total hot run time: 54892 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33042:
URL: https://github.com/apache/doris/pull/33042#issuecomment-2027041895
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 3dee516290e0609fa7bbbb507cf45fdf88cc82ee with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.8 seconds inserted 10000000 Rows, about 724K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33042:
URL: https://github.com/apache/doris/pull/33042#issuecomment-2027038666
<details>
<summary>ClickBench: <b>Total hot run time: 29.93 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3dee516290e0609fa7bbbb507cf45fdf88cc82ee, data reload: false
query1 0.04 0.03 0.03
query2 0.08 0.04 0.04
query3 0.23 0.05 0.06
query4 1.67 0.08 0.07
query5 0.49 0.47 0.50
query6 1.13 0.66 0.64
query7 0.02 0.01 0.02
query8 0.05 0.04 0.04
query9 0.56 0.49 0.50
query10 0.55 0.55 0.55
query11 0.17 0.10 0.11
query12 0.14 0.12 0.11
query13 0.60 0.58 0.59
query14 0.76 0.79 0.77
query15 0.84 0.82 0.81
query16 0.35 0.36 0.38
query17 1.03 0.97 1.02
query18 0.22 0.20 0.28
query19 1.83 1.74 1.80
query20 0.01 0.01 0.01
query21 15.54 0.64 0.64
query22 3.12 2.25 1.98
query23 17.21 1.00 0.92
query24 1.12 0.25 0.22
query25 0.09 0.09 0.08
query26 0.22 0.17 0.17
query27 0.08 0.09 0.07
query28 14.04 0.94 0.92
query29 12.58 3.21 3.25
query30 0.28 0.08 0.08
query31 2.82 0.37 0.38
query32 3.27 0.46 0.46
query33 2.88 2.90 2.87
query34 16.96 4.43 4.44
query35 4.46 4.47 4.44
query36 0.60 0.46 0.46
query37 0.18 0.14 0.14
query38 0.15 0.14 0.14
query39 0.05 0.04 0.03
query40 0.18 0.14 0.14
query41 0.10 0.05 0.05
query42 0.05 0.04 0.05
query43 0.04 0.04 0.03
Total cold run time: 106.79 s
Total hot run time: 29.93 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33042:
URL: https://github.com/apache/doris/pull/33042#issuecomment-2027027298
TeamCity be ut coverage result:
Function Coverage: 35.56% (8840/24861)
Line Coverage: 27.29% (72478/265561)
Region Coverage: 26.50% (37511/141538)
Branch Coverage: 23.31% (19121/82046)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3dee516290e0609fa7bbbb507cf45fdf88cc82ee_3dee516290e0609fa7bbbb507cf45fdf88cc82ee/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #33042:
URL: https://github.com/apache/doris/pull/33042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33042:
URL: https://github.com/apache/doris/pull/33042#issuecomment-2027184684
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on PR #33042:
URL: https://github.com/apache/doris/pull/33042#issuecomment-2026928120
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33042:
URL: https://github.com/apache/doris/pull/33042#issuecomment-2026945738
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33042:
URL: https://github.com/apache/doris/pull/33042#issuecomment-2026935968
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [BugFix] Fix rename error because the new dir exists [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33042:
URL: https://github.com/apache/doris/pull/33042#issuecomment-2026928031
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org