You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by dk...@apache.org on 2021/01/28 14:54:27 UTC
[sling-org-apache-sling-app-cms] 02/02: Minor: fixing another minor
accessibility issue
This is an automated email from the ASF dual-hosted git repository.
dklco pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-app-cms.git
commit 78affcd4ee155886cc1da9200e8f4a6e40003dc2
Author: Dan Klco <dk...@apache.org>
AuthorDate: Thu Jan 28 09:54:10 2021 -0500
Minor: fixing another minor accessibility issue
---
.../apps/reference/components/forms/fields/selection/selection.jsp | 2 +-
.../libs/sling-cms/components/editor/fields/combobox/values.jsp | 6 +++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/reference/src/main/resources/jcr_root/apps/reference/components/forms/fields/selection/selection.jsp b/reference/src/main/resources/jcr_root/apps/reference/components/forms/fields/selection/selection.jsp
index ce84bb4..0ee417e 100644
--- a/reference/src/main/resources/jcr_root/apps/reference/components/forms/fields/selection/selection.jsp
+++ b/reference/src/main/resources/jcr_root/apps/reference/components/forms/fields/selection/selection.jsp
@@ -57,7 +57,7 @@
<c:otherwise>
<select id="${properties.name}" class="form-control" ${properties.multiple ? 'multiple="multiple"' : ''} name="${properties.name}">
<c:if test="${not empty properties.noSelection && !properties.muliple}">
- <option>
+ <option value="">
<sling:encode value="${properties.noSelection}" mode="HTML" />
</option>
</c:if>
diff --git a/ui/src/main/resources/jcr_root/libs/sling-cms/components/editor/fields/combobox/values.jsp b/ui/src/main/resources/jcr_root/libs/sling-cms/components/editor/fields/combobox/values.jsp
index f365e87..b02790b 100644
--- a/ui/src/main/resources/jcr_root/libs/sling-cms/components/editor/fields/combobox/values.jsp
+++ b/ui/src/main/resources/jcr_root/libs/sling-cms/components/editor/fields/combobox/values.jsp
@@ -23,6 +23,10 @@
<span class="labelfield__title">
${sling:encode(item,'HTML')}
</span>
- <button class="delete is-small"></button>
+ <button class="delete is-small">
+ <span class="is-sr-only">
+ Delete
+ </span>
+ </button>
</a>
</c:forEach>