[GitHub] [doris] xinyiZzz commented on a diff in pull request #21069: [enhancement](memory) print stacktrace for large allocation

["xinyiZzz (via GitHub)" <gi...@apache.org>]

xinyiZzz commented on code in PR #21069:
URL: https://github.com/apache/doris/pull/21069#discussion_r1236576076


##########
be/src/runtime/memory/thread_mem_tracker_mgr.h:
##########
@@ -173,7 +173,7 @@ inline void ThreadMemTrackerMgr::consume(int64_t size) {
     }
     // Large memory alloc should use allocator.h
     // Direct malloc or new large memory, unable to catch std::bad_alloc, BE may OOM.
-    if (size > 4294967296) { // 4G
+    if (size > 1024l * 1024 * 1024) { // 4G

Review Comment:
   modify comment : )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org