Re: [PR] HDDS-10469. Ozone Manager should continue to work when S3 secret storge is unavailable [ozone]

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on code in PR #6339:
URL: https://github.com/apache/ozone/pull/6339#discussion_r1877548108


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/s3/security/S3GetSecretResponse.java:
##########
@@ -58,13 +59,10 @@ public void addToDBBatch(OMMetadataManager omMetadataManager,
     boolean isOk
         = getOMResponse().getStatus() == OzoneManagerProtocolProtos.Status.OK;
     if (s3SecretValue != null && isOk) {
-      if (s3SecretManager.isBatchSupported()) {
-        s3SecretManager.batcher().addWithBatch(batchOperation,
-            s3SecretValue.getKerberosID(), s3SecretValue);
-      } else {
-        s3SecretManager.storeSecret(s3SecretValue.getKerberosID(),
-            s3SecretValue);
-      }
+      S3Batcher batcher = s3SecretManager.batcher();
+      if (batcher != null) {

Review Comment:
   @Cyrill can you please let me know if the condition is intentionally changed?
   
   From:
   
   ```java
   if (s3SecretManager.isBatchSupported())
   ```
   
   to:
   
   ```java
   if (batcher != null)
   ```
   
   If not, can we restore the original one?
   
   Other than that, I think this patch is good to go.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org