[jira] [Resolved] (SOLR-8454) Improve logging by ZkStateReader and clean up dead code

["Shai Erera (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera resolved SOLR-8454.
------------------------------
    Resolution: Fixed

Thanks [~anshum]. Committed to trunk and 5x.

> Improve logging by ZkStateReader and clean up dead code
> -------------------------------------------------------
>
>                 Key: SOLR-8454
>                 URL: https://issues.apache.org/jira/browse/SOLR-8454
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 5.5, Trunk
>
>         Attachments: SOLR-8454.patch, SOLR-8454.patch, SOLR-8454.patch, SOLR-8454.patch
>
>
> Improve logging output by ZkStateReader, by adding the following:
> * Use LOG.foo() with parameters properly (i.e. not concatenating strings w/ +)
> * Surround parameters with [], to help readability, especially w/ empty values
> * Add missing string messages, where I felt a message will clarify
> * Convert some try-catch to a try-multicatch and improve output log message
> Also, clean up dead code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org