You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Keiron Liddle <ke...@aftexsw.com> on 2002/11/12 09:26:04 UTC
Re: cvs commit: xml-fop/src/org/apache/fop/image JpegImage.java
On Mon, 2002-11-11 at 19:30, chrisg@apache.org wrote:
> Log:
> Fixed problem with jpegs with icc profile and acrobat reader 5 (Bug #11301)
> Submitted by: Stephan Neuhaus <st...@myview.de>
I tried this change with the trunk code and I get an exception
"java.lang.IllegalArgumentException: Invalid ICC Profile Data".
The trunk code uses the java ICC profile to load and store the data.
Even though it eventually simply gets the original data to write into
the pdf document.
So does anyone know what should be done?
Should it be written out differently, or simply avoid the java ICC
stuff?
> --- JpegImage.java 2 Dec 2001 22:17:29 -0000 1.1.2.1
> +++ JpegImage.java 11 Nov 2002 18:30:15 -0000 1.1.2.2
> @@ -124,11 +124,7 @@
> int chunkSize = calcBytes(this.m_bitmaps[index + 2],
> this.m_bitmaps[index + 3]) + 2;
>
> - if (iccStream.size() == 0)
> - iccStream.write(this.m_bitmaps, index+18, chunkSize - 20);
> - else
> - iccStream.write(this.m_bitmaps, index+16, chunkSize - 18); // eller 18..
> -
> + iccStream.write(this.m_bitmaps, index+16, chunkSize - 18); // eller 18..
> }
>
> index += calcBytes(this.m_bitmaps[index + 2],
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: cvs commit: xml-fop/src/org/apache/fop/image JpegImage.java
Posted by Keiron Liddle <ke...@aftexsw.com>.
On Tue, 2002-11-12 at 09:26, Keiron Liddle wrote:
> On Mon, 2002-11-11 at 19:30, chrisg@apache.org wrote:
> > Log:
> > Fixed problem with jpegs with icc profile and acrobat reader 5 (Bug #11301)
> > Submitted by: Stephan Neuhaus <st...@myview.de>
>
> I tried this change with the trunk code and I get an exception
> "java.lang.IllegalArgumentException: Invalid ICC Profile Data".
It seems the length was wrong, with the right length it now works using
java ICC profile.
> The trunk code uses the java ICC profile to load and store the data.
> Even though it eventually simply gets the original data to write into
> the pdf document.
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: cvs commit: xml-fop/src/org/apache/fop/image JpegImage.java
Posted by Christian Geisert <ch...@isu-gmbh.de>.
Keiron Liddle wrote:
> I tried this change with the trunk code and I get an exception
> "java.lang.IllegalArgumentException: Invalid ICC Profile Data".
>
> The trunk code uses the java ICC profile to load and store the data.
> Even though it eventually simply gets the original data to write into
> the pdf document.
>
> So does anyone know what should be done?
> Should it be written out differently, or simply avoid the java ICC
> stuff?
Sorry, my knowledge about ICC color profiles is very limited.
I just tested the patch with two images successfully
and since it seems it does not break anything I committed it.
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org