[GitHub] [kafka] C0urante commented on pull request #7496: KAFKA-9018: Throw clearer exceptions on serialisation errors

[GitBox <gi...@apache.org>]

C0urante commented on pull request #7496:
URL: https://github.com/apache/kafka/pull/7496#issuecomment-871472870


   This generates excessive `ERROR`-level logging for tasks encountering deserialization errors with `errors.tolerance` set to `all`. Could we revert this change and make any improvements in the [`LogReporter`](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/LogReporter.java) and [`ProcessingContext`](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/ProcessingContext.java#L38) instead? It seems like the idiom established by [KIP-298](https://cwiki.apache.org/confluence/display/KAFKA/KIP-298%3A+Error+Handling+in+Connect) is that this information should be surfaced by adjusting the connector's `errors.log.enable` and `errors.log.include.messages` properties in an opt-in fashion, in order to avoid flooding logs with stack traces when tolerable failures are encountered frequently.
   
   @wicknicks @mmolimar @rhauch thoughts? Happy to file the appropriate Jira and PR if this sounds worth pursuing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org