You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Daniel Mohni (JIRA)" <ji...@codehaus.org> on 2010/12/23 15:02:58 UTC
[jira] Created: (MSHARED-177) Filter files are not filtered with
already known filter values
Filter files are not filtered with already known filter values
--------------------------------------------------------------
Key: MSHARED-177
URL: http://jira.codehaus.org/browse/MSHARED-177
Project: Maven Shared Components
Issue Type: Bug
Components: maven-filtering
Environment: all
Reporter: Daniel Mohni
Attachments: PropertyUtils.patch
While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
The problem is related that the current filter properties are combined before they are filterd.
The copmbined values are not updated after filtering...
Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MSHARED-177) Filter files are not
filtered with already known filter values
Posted by "Daniel Mohni (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253553#action_253553 ]
Daniel Mohni edited comment on MSHARED-177 at 1/31/11 2:05 AM:
---------------------------------------------------------------
Created UnitTest to check if already known filters are applied
was (Author: mohnid):
UnitTest to check if already known filters are applied
> Filter files are not filtered with already known filter values
> --------------------------------------------------------------
>
> Key: MSHARED-177
> URL: http://jira.codehaus.org/browse/MSHARED-177
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Environment: all
> Reporter: Daniel Mohni
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0
>
> Attachments: PropertyUtils.patch, PropertyUtilsTest.patch
>
>
> While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
> The problem is related that the current filter properties are combined before they are filterd.
> The copmbined values are not updated after filtering...
> Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHARED-177) Filter files are not filtered with
already known filter values
Posted by "Daniel Mohni (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Mohni updated MSHARED-177:
---------------------------------
Attachment: PropertyUtilsTest.patch
UnitTest to check if already known filters are applied
> Filter files are not filtered with already known filter values
> --------------------------------------------------------------
>
> Key: MSHARED-177
> URL: http://jira.codehaus.org/browse/MSHARED-177
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Environment: all
> Reporter: Daniel Mohni
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0
>
> Attachments: PropertyUtils.patch, PropertyUtilsTest.patch
>
>
> While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
> The problem is related that the current filter properties are combined before they are filterd.
> The copmbined values are not updated after filtering...
> Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-177) Filter files are not filtered with
already known filter values
Posted by "Daniel Mohni (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253612#action_253612 ]
Daniel Mohni commented on MSHARED-177:
--------------------------------------
Unfortunatly this correct. As there is no acces to the combinedProperties this can not be verified.
I think that the problem should be fixed somewhere else.
Looking deeper thru the code I don't understand why my patch worked....
I'l try to find a better patch
> Filter files are not filtered with already known filter values
> --------------------------------------------------------------
>
> Key: MSHARED-177
> URL: http://jira.codehaus.org/browse/MSHARED-177
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Environment: all
> Reporter: Daniel Mohni
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0
>
> Attachments: PropertyUtils.patch, PropertyUtilsTest.patch
>
>
> While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
> The problem is related that the current filter properties are combined before they are filterd.
> The copmbined values are not updated after filtering...
> Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHARED-177) Filter files are not filtered with
already known filter values
Posted by "Daniel Mohni (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Mohni updated MSHARED-177:
---------------------------------
Attachment: DefaultMavenFileFilter.patch
I created another patch that will fix the problem on the DefaultMavenFileFilter.
The PropertyUtils Patches are obsolete and should not be used.
I don't know how to delete the already attached files.
TestCase with FilterFiles is included
> Filter files are not filtered with already known filter values
> --------------------------------------------------------------
>
> Key: MSHARED-177
> URL: http://jira.codehaus.org/browse/MSHARED-177
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Environment: all
> Reporter: Daniel Mohni
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0
>
> Attachments: DefaultMavenFileFilter.patch, PropertyUtils.patch, PropertyUtilsTest.patch
>
>
> While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
> The problem is related that the current filter properties are combined before they are filterd.
> The copmbined values are not updated after filtering...
> Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-177) Filter files are not filtered with
already known filter values
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=249598#action_249598 ]
Olivier Lamy commented on MSHARED-177:
--------------------------------------
Hello,
I wonder if you have any unit tests for this issue (or a test project in resources plugin) ?
> Filter files are not filtered with already known filter values
> --------------------------------------------------------------
>
> Key: MSHARED-177
> URL: http://jira.codehaus.org/browse/MSHARED-177
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Environment: all
> Reporter: Daniel Mohni
> Attachments: PropertyUtils.patch
>
>
> While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
> The problem is related that the current filter properties are combined before they are filterd.
> The copmbined values are not updated after filtering...
> Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-177) Filter files are not filtered with
already known filter values
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=249639#action_249639 ]
Olivier Lamy commented on MSHARED-177:
--------------------------------------
ok sounds reasonnable use case.
Don't miss to create an issue in MASSEMBLY too for upgrading the lib version.
Thanks
> Filter files are not filtered with already known filter values
> --------------------------------------------------------------
>
> Key: MSHARED-177
> URL: http://jira.codehaus.org/browse/MSHARED-177
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Environment: all
> Reporter: Daniel Mohni
> Fix For: maven-filtering-1.0-beta-5
>
> Attachments: PropertyUtils.patch
>
>
> While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
> The problem is related that the current filter properties are combined before they are filterd.
> The copmbined values are not updated after filtering...
> Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-177) Filter files are not filtered with
already known filter values
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253566#action_253566 ]
Olivier Lamy commented on MSHARED-177:
--------------------------------------
Thanks Daniel.
But I have applied only your patch for the unit test and it doesn't fail.
I'd like to have a junit which failed without the other patch and successed with the it.
To ensure the bug is fixed.
> Filter files are not filtered with already known filter values
> --------------------------------------------------------------
>
> Key: MSHARED-177
> URL: http://jira.codehaus.org/browse/MSHARED-177
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Environment: all
> Reporter: Daniel Mohni
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0
>
> Attachments: PropertyUtils.patch, PropertyUtilsTest.patch
>
>
> While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
> The problem is related that the current filter properties are combined before they are filterd.
> The copmbined values are not updated after filtering...
> Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSHARED-177) Filter files are not filtered with
already known filter values
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed MSHARED-177.
--------------------------------
Resolution: Fixed
fixed [rev 1065840|http://svn.apache.org/viewvc?rev=1065840&view=rev]
Thanks !
> Filter files are not filtered with already known filter values
> --------------------------------------------------------------
>
> Key: MSHARED-177
> URL: http://jira.codehaus.org/browse/MSHARED-177
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Environment: all
> Reporter: Daniel Mohni
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0
>
> Attachments: DefaultMavenFileFilter.patch, PropertyUtils.patch, PropertyUtilsTest.patch
>
>
> While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
> The problem is related that the current filter properties are combined before they are filterd.
> The copmbined values are not updated after filtering...
> Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHARED-177) Filter files are not filtered with
already known filter values
Posted by "Daniel Mohni (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=249634#action_249634 ]
Daniel Mohni commented on MSHARED-177:
--------------------------------------
I will create a unit test for this issue when I am back from holiday, but this will have to wait until end of January when I get back to work...
I faced the problem working on a customer site project, using the assembly-plugin version 2.2, we used multiple filter files to create environment specific configurations.
Filter File A contains portions of a value of Filter File B, using the key of File B to replace a value in a resource file still contained the key of File A...
> Filter files are not filtered with already known filter values
> --------------------------------------------------------------
>
> Key: MSHARED-177
> URL: http://jira.codehaus.org/browse/MSHARED-177
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Environment: all
> Reporter: Daniel Mohni
> Attachments: PropertyUtils.patch
>
>
> While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
> The problem is related that the current filter properties are combined before they are filterd.
> The copmbined values are not updated after filtering...
> Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHARED-177) Filter files are not filtered with
already known filter values
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHARED-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated MSHARED-177:
---------------------------------
Fix Version/s: maven-filtering-1.0-beta-5
> Filter files are not filtered with already known filter values
> --------------------------------------------------------------
>
> Key: MSHARED-177
> URL: http://jira.codehaus.org/browse/MSHARED-177
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-filtering
> Environment: all
> Reporter: Daniel Mohni
> Assignee: Olivier Lamy
> Fix For: maven-filtering-1.0-beta-5
>
> Attachments: PropertyUtils.patch
>
>
> While loading multiple Filter files the current file is filtered but the combined filter properties are not updated.
> The problem is related that the current filter properties are combined before they are filterd.
> The copmbined values are not updated after filtering...
> Attached is a patch that will also update the value in the combinedProperties
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira