You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2025/07/29 22:28:54 UTC
(superset) branch fix/theme-list-button-order created (now 3c9d331014)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a change to branch fix/theme-list-button-order
in repository https://gitbox.apache.org/repos/asf/superset.git
at 3c9d331014 fix(theme-list): reorder buttons to place import leftmost
This branch includes the following new commits:
new 3c9d331014 fix(theme-list): reorder buttons to place import leftmost
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(superset) 01/01: fix(theme-list): reorder buttons to place import leftmost
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch fix/theme-list-button-order
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 3c9d33101455bb727b5bf709a7331127b7bb55e9
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Jul 29 22:27:56 2025 +0000
fix(theme-list): reorder buttons to place import leftmost
Move the import button to be the leftmost button in the Theme CRUD interface,
with the add theme button as the rightmost button. This improves UI consistency
across different list views in Superset.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <no...@anthropic.com>
---
superset-frontend/src/pages/ThemeList/index.tsx | 32 ++++++++++++-------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/superset-frontend/src/pages/ThemeList/index.tsx b/superset-frontend/src/pages/ThemeList/index.tsx
index 36419c4e11..c9ec06dc00 100644
--- a/superset-frontend/src/pages/ThemeList/index.tsx
+++ b/superset-frontend/src/pages/ThemeList/index.tsx
@@ -338,6 +338,22 @@ function ThemesList({
const subMenuButtons: SubMenuProps['buttons'] = [];
+ if (canImport) {
+ subMenuButtons.push({
+ name: (
+ <Tooltip
+ id="import-tooltip"
+ title={t('Import themes')}
+ placement="bottomRight"
+ >
+ <Icons.DownloadOutlined iconSize="l" data-test="import-button" />
+ </Tooltip>
+ ),
+ buttonStyle: 'link',
+ onClick: openThemeImportModal,
+ });
+ }
+
if (canDelete || canExport) {
subMenuButtons.push({
name: t('Bulk select'),
@@ -358,22 +374,6 @@ function ThemesList({
});
}
- if (canImport) {
- subMenuButtons.push({
- name: (
- <Tooltip
- id="import-tooltip"
- title={t('Import themes')}
- placement="bottomRight"
- >
- <Icons.DownloadOutlined iconSize="l" data-test="import-button" />
- </Tooltip>
- ),
- buttonStyle: 'link',
- onClick: openThemeImportModal,
- });
- }
-
menuData.buttons = subMenuButtons;
const filters: ListViewFilters = useMemo(