You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Carsten Schinzer (JIRA)" <ji...@apache.org> on 2012/10/21 11:00:12 UTC
[jira] [Updated] (OFBIZ-5057) Image rendering issue on
productdetail.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Schinzer updated OFBIZ-5057:
------------------------------------
Description:
Reference: Line 358
! <#if productImageList?has_content>
A validation seems to have been introduced by rev. 1345532 where before on the FTL if clause, both checks (not null and hs content) were executed while now they are no longer. This leads to a failure to render of no related Content Images are on the Product but only attributed image URLs.
1 <#if productImageList?if_exists && productImageList?has_content>
Does the trick, so would the earlier version:
2 <#if productImageList != null && productImageList?has_content>
I also assume that with rev. 1345532 it was intended to put this here:
3 <#if productImageList?? && productImageList?has_content>
I leave it to the FTL pros to comment and recommend for ca. 24 hours.
If no comment by tomorrow, I shall propose to use the former code corresponding to [3] as this is what was the latest agreement made on OFBIZ-4916.
was:
Reference: Line 358
[!] <#if productImageList?has_content>
A validation seems to have been introduced by rev. 1345532 where before on the FTL if clause, both checks (not null and hs content) were executed while now they are no longer. This leads to a failure to render of no related Content Images are on the Product but only attributed image URLs.
[1] <#if productImageList?if_exists && productImageList?has_content>
Does the trick, so would the earlier version:
[2] <#if productImageList != null && productImageList?has_content>
I also assume that with rev. 1345532 it was intended to put this here:
[3] <#if productImageList?? && productImageList?has_content>
I leave it to the FTL pros to comment and recommend for ca. 24 hours.
If no comment by tomorrow, I shall propose to use the former code corresponding to [3] as this is what was the latest agreement made on OFBIZ-4916.
Remaining Estimate: 0h
Original Estimate: 0h
> Image rendering issue on productdetail.ftl
> ------------------------------------------
>
> Key: OFBIZ-5057
> URL: https://issues.apache.org/jira/browse/OFBIZ-5057
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Environment: FTL code, not relevant
> Reporter: Carsten Schinzer
> Priority: Minor
> Fix For: SVN trunk
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Reference: Line 358
> ! <#if productImageList?has_content>
> A validation seems to have been introduced by rev. 1345532 where before on the FTL if clause, both checks (not null and hs content) were executed while now they are no longer. This leads to a failure to render of no related Content Images are on the Product but only attributed image URLs.
> 1 <#if productImageList?if_exists && productImageList?has_content>
> Does the trick, so would the earlier version:
> 2 <#if productImageList != null && productImageList?has_content>
> I also assume that with rev. 1345532 it was intended to put this here:
> 3 <#if productImageList?? && productImageList?has_content>
> I leave it to the FTL pros to comment and recommend for ca. 24 hours.
> If no comment by tomorrow, I shall propose to use the former code corresponding to [3] as this is what was the latest agreement made on OFBIZ-4916.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira