You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/07/24 23:11:24 UTC
Review Request 61093: Windows: Disabled permissive building.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61093/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
This flag enables warnings for non standards conformant code.
Diffs
-----
cmake/CompilationConfigure.cmake 847ae1aeea61ce9082cbcea16138f447c9558243
Diff: https://reviews.apache.org/r/61093/diff/1/
Testing
-------
Warning: this requires Visual Studio 2017.
Built all test targets on Windows.
Observed: `... /errorReport:queue /bigobj /vd2 /permissive- /Zm170 "C:\Users\andschwa\src\mesos-bugfix\src\slave\constants.cpp`
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61093: Windows: Disabled permissive building.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61093/#review181289
-----------------------------------------------------------
Ship it!
The additional flag looks odd enough to warrant putting this blog post in a comment or commit message somewhere:
https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/
- Joseph Wu
On July 24, 2017, 4:11 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61093/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 4:11 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag enables warnings for non standards conformant code.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 847ae1aeea61ce9082cbcea16138f447c9558243
>
>
> Diff: https://reviews.apache.org/r/61093/diff/1/
>
>
> Testing
> -------
>
> Warning: this requires Visual Studio 2017.
>
> Built all test targets on Windows.
>
> Observed: `... /errorReport:queue /bigobj /vd2 /permissive- /Zm170 "C:\Users\andschwa\src\mesos-bugfix\src\slave\constants.cpp`
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61093: Windows: Disabled permissive building.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61093/#review181290
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On July 24, 2017, 4:11 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61093/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 4:11 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag enables warnings for non standards conformant code.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 847ae1aeea61ce9082cbcea16138f447c9558243
>
>
> Diff: https://reviews.apache.org/r/61093/diff/1/
>
>
> Testing
> -------
>
> Warning: this requires Visual Studio 2017.
>
> Built all test targets on Windows.
>
> Observed: `... /errorReport:queue /bigobj /vd2 /permissive- /Zm170 "C:\Users\andschwa\src\mesos-bugfix\src\slave\constants.cpp`
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>