You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/01/22 19:59:16 UTC
svn commit: r1779854 - in /jmeter/trunk/src:
components/org/apache/jmeter/visualizers/backend/influxdb/
protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/
Author: pmouawad
Date: Sun Jan 22 19:59:16 2017
New Revision: 1779854
URL: http://svn.apache.org/viewvc?rev=1779854&view=rev
Log:
Fix sonar code smells
Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/HttpMetricsSender.java
jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SecuritySettingsPanel.java
jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/HttpMetricsSender.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/HttpMetricsSender.java?rev=1779854&r1=1779853&r2=1779854&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/HttpMetricsSender.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/HttpMetricsSender.java Sun Jan 22 19:59:16 2017
@@ -162,7 +162,7 @@ class HttpMetricsSender extends Abstract
httpRequest.setEntity(entity);
lastRequest = httpClient.execute(httpRequest, new FutureCallback<HttpResponse>() {
-
+ @Override
public void completed(final HttpResponse response) {
int code = response.getStatusLine().getStatusCode();
/*
@@ -183,15 +183,14 @@ class HttpMetricsSender extends Abstract
}
}
}
-
+ @Override
public void failed(final Exception ex) {
LOG.error("failed to send data to influxDB server : " + ex.getMessage());
}
-
+ @Override
public void cancelled() {
LOG.warn("Request to influxDB server was cancelled");
}
-
});
}catch (URISyntaxException ex ) {
Modified: jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SecuritySettingsPanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SecuritySettingsPanel.java?rev=1779854&r1=1779853&r2=1779854&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SecuritySettingsPanel.java (original)
+++ jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SecuritySettingsPanel.java Sun Jan 22 19:59:16 2017
@@ -168,7 +168,7 @@ public class SecuritySettingsPanel exten
* @param evt
* ActionEvent to be handled
*/
- private void cbUseLocalTrustStoreActionPerformed(
+ private void cbUseLocalTrustStoreActionPerformed( // NOSONAR This method is used through lambda
ActionEvent evt) {
final boolean selected = cbUseLocalTrustStore.isSelected();
tfTrustStoreToUse.setEditable(selected); // must follow the checkbox setting
@@ -182,7 +182,7 @@ public class SecuritySettingsPanel exten
* @param evt
* ActionEvent to be handled
*/
- private void cbTrustAllCertsActionPerformed(
+ private void cbTrustAllCertsActionPerformed( // NOSONAR This method is used through lambda
ActionEvent evt) {
final boolean selected = cbTrustAllCerts.isSelected();
if (selected) {
@@ -198,7 +198,8 @@ public class SecuritySettingsPanel exten
* @param evt
* ActionEvent to be handled
*/
- private void cbEnforceStartTLSActionPerformed(ActionEvent evt) {
+ private void cbEnforceStartTLSActionPerformed(ActionEvent evt) { // NOSONAR This method is used through lambda
+ // NOOP
}
/**
@@ -207,7 +208,7 @@ public class SecuritySettingsPanel exten
* @param evt
* ItemEvent to be handled
*/
- private void rbSecuritySettingsItemStateChanged(ItemEvent evt) {
+ private void rbSecuritySettingsItemStateChanged(ItemEvent evt) { // NOSONAR This method is used through lambda
final Object source = evt.getSource();
if (source == rbUseNone) {
cbTrustAllCerts.setEnabled(false);
Modified: jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java?rev=1779854&r1=1779853&r2=1779854&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java (original)
+++ jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java Sun Jan 22 19:59:16 2017
@@ -894,7 +894,7 @@ public class SmtpPanel extends JPanel {
* @param evt
* ActionEvent to be handled
*/
- private void cbUseAuthActionPerformed(ActionEvent evt) {
+ private void cbUseAuthActionPerformed(ActionEvent evt) { // NOSONAR This method is used through lambda
tfAuthUsername.setEditable(cbUseAuth.isSelected());
tfAuthPassword.setEditable(cbUseAuth.isSelected());
}
@@ -906,7 +906,7 @@ public class SmtpPanel extends JPanel {
* @param evt
* ActionEvent to be handled
*/
- private void attachmentFolderFileChooserActionPerformed(ActionEvent evt) {
+ private void attachmentFolderFileChooserActionPerformed(ActionEvent evt) { // NOSONAR This method is used through lambda
File chosen = attachmentFileChooser.getSelectedFile();
if (chosen == null) {
return;
@@ -927,32 +927,20 @@ public class SmtpPanel extends JPanel {
* @param evt
* ActionEvent to be handled
*/
- private void browseButtonActionPerformed(ActionEvent evt) {
+ private void browseButtonActionPerformed(ActionEvent evt) { // NOSONAR This method is used through lambda
attachmentFileChooser.showOpenDialog(this);
}
- private void cbUseEmlMessageActionPerformed(ActionEvent evt) {
+ private void cbUseEmlMessageActionPerformed(ActionEvent evt) { // NOSONAR This method is used through lambda
if (cbUseEmlMessage.isSelected()) {
tfEmlMessage.setEnabled(true);
emlBrowseButton.setEnabled(true);
-
- /*tfMailFrom.setEnabled(false);
- tfMailTo.setEnabled(false);
- tfMailToCC.setEnabled(false);
- tfMailToBCC.setEnabled(false);
- tfSubject.setEnabled(false);*/
taMessage.setEnabled(false);
tfAttachment.setEnabled(false);
browseButton.setEnabled(false);
} else {
tfEmlMessage.setEnabled(false);
emlBrowseButton.setEnabled(false);
-
- /*tfMailFrom.setEnabled(true);
- tfMailTo.setEnabled(true);
- tfMailToCC.setEnabled(true);
- tfMailToBCC.setEnabled(true);
- tfSubject.setEnabled(true);*/
taMessage.setEnabled(true);
tfAttachment.setEnabled(true);
browseButton.setEnabled(true);
@@ -966,7 +954,7 @@ public class SmtpPanel extends JPanel {
* @param evt
* ActionEvent to be handled
*/
- private void emlFileChooserActionPerformed(ActionEvent evt) {
+ private void emlFileChooserActionPerformed(ActionEvent evt) { // NOSONAR This method is used through lambda
tfEmlMessage.setText(emlFileChooser.getSelectedFile().getAbsolutePath());
}
@@ -976,7 +964,7 @@ public class SmtpPanel extends JPanel {
* @param evt
* ActionEvent to be handled
*/
- private void emlBrowseButtonActionPerformed(ActionEvent evt) {
+ private void emlBrowseButtonActionPerformed(ActionEvent evt) { // NOSONAR This method is used through lambda
emlFileChooser.showOpenDialog(this);
}
@@ -1074,7 +1062,7 @@ public class SmtpPanel extends JPanel {
this.securitySettingsPanel = securitySettingsPanel;
}
- private void removeHeaderActionPerformed(ActionEvent evt){
+ private void removeHeaderActionPerformed(ActionEvent evt){ // NOSONAR This method is used through lambda
final Object source = evt.getSource();
if(source instanceof JButton){
if(headerFields.size() == 1){
@@ -1091,7 +1079,8 @@ public class SmtpPanel extends JPanel {
validate();
}
}
- private void emptySubjectActionPerformed(ChangeEvent evt) {
+
+ private void emptySubjectActionPerformed(ChangeEvent evt) { // NOSONAR This method is used through lambda
final Object source = evt.getSource();
if(source instanceof JCheckBox){
if(cbSuppressSubject.isSelected()){