You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "nirroz93 (via GitHub)" <gi...@apache.org> on 2024/03/21 09:23:06 UTC
[PR] Add persistent volume claim retention policy [airflow]
nirroz93 opened a new pull request, #38361:
URL: https://github.com/apache/airflow/pull/38361
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
Add persistentVolumeClaimRetentionPolicy available since k8s 1.23 (alpha) and 1.27 (beta). With logs, this makes a lot of sense (with remote logging only running task log is important, and on scale down pvc should be removed)
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add persistent volume claim retention policy [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38361:
URL: https://github.com/apache/airflow/pull/38361#issuecomment-2156916588
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add persistent volume claim retention policy [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #38361:
URL: https://github.com/apache/airflow/pull/38361#discussion_r1566840390
##########
chart/values.yaml:
##########
@@ -1426,6 +1431,8 @@ triggerer:
persistence:
# Enable persistent volumes
enabled: true
+ # persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled\removed
Review Comment:
```suggestion
# persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled/removed
```
##########
chart/values.yaml:
##########
@@ -617,6 +617,11 @@ workers:
persistence:
# Enable persistent volumes
enabled: true
+ # persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled\removed
Review Comment:
nit:
```suggestion
# persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled/removed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add persistent volume claim retention policy [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #38361:
URL: https://github.com/apache/airflow/pull/38361#issuecomment-2172381079
@nirroz93 are you actively working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add persistent volume claim retention policy [airflow]
Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on PR #38361:
URL: https://github.com/apache/airflow/pull/38361#issuecomment-2172315547
> @nirroz93 good work on the PR. Few comments:
>
> 1. Can we add this also to `chart/files/pod-template-file.kubernetes-helm-yaml` for K8sExecutor?
> 2. Can we add unit tests foe this under `helm_tests`? Check similar tests.
> @nirroz93 good work on the PR. Few comments:
>
> 1. Can we add this also to `chart/files/pod-template-file.kubernetes-helm-yaml` for K8sExecutor?
> 2. Can we add unit tests foe this under `helm_tests`? Check similar tests.
no need to add this to `chart/files/pod-template-file.kubernetes-helm-yaml` because this feature belongs only to statefulset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org