You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/08/27 13:04:22 UTC

[GitHub] [storm] agresch commented on a change in pull request #3113: STORM-3482 Implement One Worker Per Component Option

agresch commented on a change in pull request #3113: STORM-3482 Implement One Worker Per Component Option
URL: https://github.com/apache/storm/pull/3113#discussion_r318066983
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java
 ##########
 @@ -154,10 +167,8 @@ protected WorkerSlot findWorkerForExec(ExecutorDetails exec, TopologyDetails td,
             if (node.couldEverFit(exec, td)) {
                 Collection<WorkerSlot> topologyUsedSlots = oneExecutorPerWorker ? node.getUsedSlots(td.getId()) : Collections.emptySet();
 
 Review comment:
   topologyUsedSlots is no longer used.  It could be removed, but I'm unclear why the check was removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services