You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jackye1995 (via GitHub)" <gi...@apache.org> on 2023/02/09 02:04:46 UTC

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6777: Core: TableMetadata Always Strips Trailing Slash From Location

jackye1995 commented on code in PR #6777:
URL: https://github.com/apache/iceberg/pull/6777#discussion_r1100891080


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -290,7 +291,7 @@ public String toString() {
     this.metadataFileLocation = metadataFileLocation;
     this.formatVersion = formatVersion;
     this.uuid = uuid;
-    this.location = location;
+    this.location = location != null ? LocationUtil.stripTrailingSlash(location) : null;

Review Comment:
   I think this is the only place location could be null? In all other places location is already initialized and must be non-null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org