You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ta...@apache.org on 2016/05/17 17:01:05 UTC

activemq git commit: Fix test timing out on slow spinning disks.

Repository: activemq
Updated Branches:
  refs/heads/master 1263dd8c4 -> 2c3046b81


Fix test timing out on slow spinning disks.  

On a local drive with heave I/O this test took over 2.5 minutes to
complete, CI machines can see similar times, bumped timeout to 5 minutes
to account for this range.  

Project: http://git-wip-us.apache.org/repos/asf/activemq/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq/commit/2c3046b8
Tree: http://git-wip-us.apache.org/repos/asf/activemq/tree/2c3046b8
Diff: http://git-wip-us.apache.org/repos/asf/activemq/diff/2c3046b8

Branch: refs/heads/master
Commit: 2c3046b81616c52be5e5d45f99ee7e648d6939a4
Parents: 1263dd8
Author: Timothy Bish <ta...@gmail.com>
Authored: Tue May 17 13:00:56 2016 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Tue May 17 13:00:56 2016 -0400

----------------------------------------------------------------------
 .../test/java/org/apache/activemq/store/PListTestSupport.java  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq/blob/2c3046b8/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
----------------------------------------------------------------------
diff --git a/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java b/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
index 152f96a..2b4a779 100644
--- a/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
+++ b/activemq-broker/src/test/java/org/apache/activemq/store/PListTestSupport.java
@@ -273,7 +273,8 @@ public abstract class PListTestSupport {
         executor.execute(new B());
 
         executor.shutdown();
-        boolean finishedInTime = executor.awaitTermination(60, TimeUnit.SECONDS);
+        boolean finishedInTime = executor.awaitTermination(5, TimeUnit.MINUTES);
+        LOG.info("Tested completion finished in time? -> {}", finishedInTime ? "YES" : "NO");
 
         assertTrue("no exceptions", exceptions.isEmpty());
         assertTrue("finished ok", finishedInTime);
@@ -644,7 +645,8 @@ public abstract class PListTestSupport {
 
     @Before
     public void setUp() throws Exception {
-        File directory = new File("target/test/PlistDB");
+        //File directory = new File("target/test/PlistDB");
+        File directory = new File("/sandbox/temp/plist");
         IOHelper.mkdirs(directory);
         IOHelper.deleteChildren(directory);
         startStore(directory);