You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Vrushali C (JIRA)" <ji...@apache.org> on 2016/07/06 22:04:11 UTC
[jira] [Comment Edited] (YARN-5229) Refactor #isApplicationEntity
and #getApplicationEvent from HBaseTimelineWriterImpl
[ https://issues.apache.org/jira/browse/YARN-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365197#comment-15365197 ]
Vrushali C edited comment on YARN-5229 at 7/6/16 10:04 PM:
-----------------------------------------------------------
Thanks for the review [~gtCarrera9], uploading v4 that addresses the build report flags for license and javadoc
was (Author: vrushalic):
Thanks for the review [~gtCarrera9]], uploading v4 that addresses the build report flags for license and javadoc
> Refactor #isApplicationEntity and #getApplicationEvent from HBaseTimelineWriterImpl
> -----------------------------------------------------------------------------------
>
> Key: YARN-5229
> URL: https://issues.apache.org/jira/browse/YARN-5229
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Joep Rottinghuis
> Assignee: Vrushali C
> Priority: Minor
> Attachments: YARN-5229-YARN-2928.01.patch, YARN-5229-YARN-2928.02.patch, YARN-5229-YARN-2928.03.patch, YARN-5229-YARN-2928.04.patch
>
>
> As per [~gtCarrera9] commented in YARN-5170
> bq. In HBaseTimelineWriterImpl isApplicationEntity and getApplicationEvent seem to be awkward. Looks more like something related to TimelineEntity or ApplicationEntity
> In YARN-5170 we just made the method private, and in this separate jira we can refactor these methods to TimelineEntity or ApplicationEntity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org