[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

[GitBox <gi...@apache.org>]

xinyiZzz commented on code in PR #9870:
URL: https://github.com/apache/incubator-doris/pull/9870#discussion_r885130836


##########
be/src/runtime/minidump.cpp:
##########
@@ -32,11 +32,12 @@ int Minidump::_signo = SIGUSR1;
 std::unique_ptr<google_breakpad::ExceptionHandler> Minidump::_error_handler = nullptr;
 
 // Save the absolute path and create_time of a minidump file
-struct FileStat {
+struct MinidumpFileStat {
     std::string abs_path;

Review Comment:
   I agree,
   Usually online clusters do not enable core dump, not sure if minidump will help



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org