[jira] Commented: (THRIFT-185) Struct doesn't check if struct fields are of proper struct type when Thrift.type_checking is on

["Bryan Duxbury (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656078#action_12656078 ] 

Bryan Duxbury commented on THRIFT-185:
--------------------------------------

This issue looks ready to commit.

> Struct doesn't check if struct fields are of proper struct type when Thrift.type_checking is on
> -----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-185
>                 URL: https://issues.apache.org/jira/browse/THRIFT-185
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Bryan Duxbury
>            Assignee: Piotr Kozikowski
>            Priority: Minor
>         Attachments: thrift-185-test.patch, thrift-185-v2.patch, thrift-185-v3.patch, thrift-185.patch
>
>
> When creating a Thrift struct via the constructor, if type_checking is on, you'd expect the code to complain if you pass in the wrong kind of struct. However, the type checking code only verifies that it is a Struct, not that it is the right *kind* of struct. This is inconsistent behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.