You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sh...@apache.org on 2016/08/31 23:56:46 UTC
spark git commit: [SPARK-16581][SPARKR] Fix JVM API tests in SparkR
Repository: spark
Updated Branches:
refs/heads/master d375c8a3d -> 2f9c27364
[SPARK-16581][SPARKR] Fix JVM API tests in SparkR
## What changes were proposed in this pull request?
Remove cleanup.jobj test. Use JVM wrapper API for other test cases.
## How was this patch tested?
Run R unit tests with testthat 1.0
Author: Shivaram Venkataraman <sh...@cs.berkeley.edu>
Closes #14904 from shivaram/sparkr-jvm-tests-fix.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/2f9c2736
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/2f9c2736
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/2f9c2736
Branch: refs/heads/master
Commit: 2f9c27364ea00473933213700edb93b63b55b313
Parents: d375c8a
Author: Shivaram Venkataraman <sh...@cs.berkeley.edu>
Authored: Wed Aug 31 16:56:41 2016 -0700
Committer: Shivaram Venkataraman <sh...@cs.berkeley.edu>
Committed: Wed Aug 31 16:56:41 2016 -0700
----------------------------------------------------------------------
R/pkg/inst/tests/testthat/test_jvm_api.R | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/2f9c2736/R/pkg/inst/tests/testthat/test_jvm_api.R
----------------------------------------------------------------------
diff --git a/R/pkg/inst/tests/testthat/test_jvm_api.R b/R/pkg/inst/tests/testthat/test_jvm_api.R
index 151c529..7348c89 100644
--- a/R/pkg/inst/tests/testthat/test_jvm_api.R
+++ b/R/pkg/inst/tests/testthat/test_jvm_api.R
@@ -20,24 +20,17 @@ context("JVM API")
sparkSession <- sparkR.session(enableHiveSupport = FALSE)
test_that("Create and call methods on object", {
- jarr <- newJObject("java.util.ArrayList")
+ jarr <- sparkR.newJObject("java.util.ArrayList")
# Add an element to the array
- callJMethod(jarr, "add", 1L)
+ sparkR.callJMethod(jarr, "add", 1L)
# Check if get returns the same element
- expect_equal(callJMethod(jarr, "get", 0L), 1L)
+ expect_equal(sparkR.callJMethod(jarr, "get", 0L), 1L)
})
test_that("Call static methods", {
# Convert a boolean to a string
- strTrue <- callJStatic("java.lang.String", "valueOf", TRUE)
+ strTrue <- sparkR.callJStatic("java.lang.String", "valueOf", TRUE)
expect_equal(strTrue, "true")
})
-test_that("Manually garbage collect objects", {
- jarr <- newJObject("java.util.ArrayList")
- cleanup.jobj(jarr)
- # Using a jobj after GC should throw an error
- expect_error(print(jarr), "Error in invokeJava.*")
-})
-
sparkR.session.stop()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org