You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/12/02 22:47:41 UTC
[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request
#4876: Capture the exact UPDATE operation in DefaultColumnHandler
mcvsubbu commented on a change in pull request #4876: Capture the exact UPDATE operation in DefaultColumnHandler
URL: https://github.com/apache/incubator-pinot/pull/4876#discussion_r352900758
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
##########
@@ -188,13 +197,22 @@ public void updateDefaultColumns()
defaultValueInSchema = fieldSpecInSchema.getDefaultNullValue().toString();
}
- if (dataTypeInMetadata != dataTypeInSchema || isSingleValueInMetadata != isSingleValueInSchema
- || !defaultValueInSchema.equals(defaultValueInMetadata)) {
- if (fieldTypeInMetadata == FieldSpec.FieldType.DIMENSION) {
- defaultColumnActionMap.put(column, DefaultColumnAction.UPDATE_DIMENSION);
- } else {
- Preconditions.checkState(fieldTypeInMetadata == FieldSpec.FieldType.METRIC);
- defaultColumnActionMap.put(column, DefaultColumnAction.UPDATE_METRIC);
+ if (fieldTypeInMetadata == FieldSpec.FieldType.DIMENSION) {
+ if (dataTypeInMetadata != dataTypeInSchema) {
+ defaultColumnActionMap.put(column, DefaultColumnAction.UPDATE_DIMENSION_DATA_TYPE);
Review comment:
why allow incompatible schema operations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org