You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/03/24 11:39:29 UTC
Re: Review Request 65585: Improved documentation regarding the new
CLI setup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65585/
-----------------------------------------------------------
(Updated March 24, 2018, 11:39 a.m.)
Review request for mesos, Benjamin Bannier and Kevin Klues.
Changes
-------
Rebased.
Bugs: MESOS-8240
https://issues.apache.org/jira/browse/MESOS-8240
Repository: mesos
Description
-------
Explains how to create the necessary virtual environment from
anywhere and how to set up autocompletion in such case.
Also removes an unnecessary activation of the virtual environment
in `mesos` and `mesos-cli-tests`.
Diffs (updated)
-----
src/python/cli_new/README.md 847141db9a1f9eb5c78b2d50367b599a5c72ce61
src/python/cli_new/bin/mesos c5152a2ebf8704c804bb4f39e46580a512aecdea
src/python/cli_new/bin/mesos-cli-tests 07659e0b4551c2381828b256608d2c6ced3ae745
src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
Diff: https://reviews.apache.org/r/65585/diff/4/
Changes: https://reviews.apache.org/r/65585/diff/3-4/
Testing
-------
On Fedora 25:
```
apache-mesos (MESOS-8240)$ cd src/python/cli_new/
cli_new (MESOS-8240)$ ./bootstrap
cli_new (MESOS-8240)$ source .virtualenv/activate
(mesos-cli) cli_new (MESOS-8240)$ mesos
Mesos CLI
Usage:
mesos (-h | --help)
mesos --version
mesos <command> [<args>...]
Options:
-h --help Show this screen.
--version Show version info.
Commands:
agent Interacts with the Mesos agents
config Interacts with the Mesos CLI configuration file
task Interacts with the tasks running in a Mesos cluster
See 'mesos help <command>' for more information on a specific command.
(mesos-cli) cli_new (MESOS-8240)$ source deactivate
cli_new (MESOS-8240)$ rm -rf .virtualenv/
cli_new (MESOS-8240)$ cd ..
python (MESOS-8240)$ VIRTUALENV_DIRECTORY=$(pwd)/.venv ./cli_new/bootstrap
python (MESOS-8240)$ source /home/agrillet/apache-mesos/src/python/.venv/bin/activate
python (MESOS-8240)$ source /home/agrillet/apache-mesos/src/python/.venv/bin/postactivate
(mesos-cli) python (MESOS-8240)$ mesos
Mesos CLI
Usage:
mesos (-h | --help)
mesos --version
mesos <command> [<args>...]
Options:
-h --help Show this screen.
--version Show version info.
Commands:
agent Interacts with the Mesos agents
config Interacts with the Mesos CLI configuration file
task Interacts with the tasks running in a Mesos cluster
See 'mesos help <command>' for more information on a specific command.
```
Thanks,
Armand Grillet
Re: Review Request 65585: Improved documentation regarding the new
CLI setup.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65585/#review200997
-----------------------------------------------------------
src/python/cli_new/bootstrap
Lines 120 (patched)
<https://reviews.apache.org/r/65585/#comment281927>
This should be ${CURRDIR} too.
There is no need to introduce a new ${BINDIR} here.
- Kevin Klues
On March 24, 2018, 11:39 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65585/
> -----------------------------------------------------------
>
> (Updated March 24, 2018, 11:39 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Kevin Klues.
>
>
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Explains how to create the necessary virtual environment from
> anywhere and how to set up autocompletion in such case.
>
> Also removes an unnecessary activation of the virtual environment
> in `mesos` and `mesos-cli-tests`.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md 847141db9a1f9eb5c78b2d50367b599a5c72ce61
> src/python/cli_new/bin/mesos c5152a2ebf8704c804bb4f39e46580a512aecdea
> src/python/cli_new/bin/mesos-cli-tests 07659e0b4551c2381828b256608d2c6ced3ae745
> src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
>
>
> Diff: https://reviews.apache.org/r/65585/diff/5/
>
>
> Testing
> -------
>
> On Fedora 25:
> ```
> apache-mesos (MESOS-8240)$ cd src/python/cli_new/
> cli_new (MESOS-8240)$ ./bootstrap
> cli_new (MESOS-8240)$ source .virtualenv/activate
> (mesos-cli) cli_new (MESOS-8240)$ mesos
> Mesos CLI
>
> Usage:
> mesos (-h | --help)
> mesos --version
> mesos <command> [<args>...]
>
> Options:
> -h --help Show this screen.
> --version Show version info.
>
> Commands:
> agent Interacts with the Mesos agents
> config Interacts with the Mesos CLI configuration file
> task Interacts with the tasks running in a Mesos cluster
>
> See 'mesos help <command>' for more information on a specific command.
> (mesos-cli) cli_new (MESOS-8240)$ source deactivate
> cli_new (MESOS-8240)$ rm -rf .virtualenv/
> cli_new (MESOS-8240)$ cd ..
> python (MESOS-8240)$ VIRTUALENV_DIRECTORY=$(pwd)/.venv ./cli_new/bootstrap
> python (MESOS-8240)$ source /home/agrillet/apache-mesos/src/python/.venv/bin/activate
> python (MESOS-8240)$ source /home/agrillet/apache-mesos/src/python/.venv/bin/postactivate
> (mesos-cli) python (MESOS-8240)$ mesos
> Mesos CLI
>
> Usage:
> mesos (-h | --help)
> mesos --version
> mesos <command> [<args>...]
>
> Options:
> -h --help Show this screen.
> --version Show version info.
>
> Commands:
> agent Interacts with the Mesos agents
> config Interacts with the Mesos CLI configuration file
> task Interacts with the tasks running in a Mesos cluster
>
> See 'mesos help <command>' for more information on a specific command.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65585: Improved documentation regarding the new
CLI setup.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65585/#review200993
-----------------------------------------------------------
src/python/cli_new/README.md
Lines 40 (patched)
<https://reviews.apache.org/r/65585/#comment281922>
$ export VIRTUALENV_DIRECTORY=~/.mesos-cli-venv
$ ${MESOS_DIR}/src/python/cli_new/bootstrap
src/python/cli_new/README.md
Lines 50-54 (patched)
<https://reviews.apache.org/r/65585/#comment281923>
Likewise, I'd change this to:
```
$ source ~/.mesos-cli-venv/bin/activate
$ source ~/.mesos-cli-venv/bin/postactivate
$ mesos <command> [<args>...]
$ source ~/.mesos-cli-venv/bin/predeactivate
$ deactivate
```
src/python/cli_new/README.md
Lines 56-61 (patched)
<https://reviews.apache.org/r/65585/#comment281924>
Change referecnes of:
`/home/apache-mesos/`
to
`${MESOS_DIR}`
src/python/cli_new/bootstrap
Lines 105-108 (original), 103-124 (patched)
<https://reviews.apache.org/r/65585/#comment281925>
This will need to be changed to reflect the above comment.
- Kevin Klues
On March 24, 2018, 11:39 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65585/
> -----------------------------------------------------------
>
> (Updated March 24, 2018, 11:39 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Kevin Klues.
>
>
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Explains how to create the necessary virtual environment from
> anywhere and how to set up autocompletion in such case.
>
> Also removes an unnecessary activation of the virtual environment
> in `mesos` and `mesos-cli-tests`.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md 847141db9a1f9eb5c78b2d50367b599a5c72ce61
> src/python/cli_new/bin/mesos c5152a2ebf8704c804bb4f39e46580a512aecdea
> src/python/cli_new/bin/mesos-cli-tests 07659e0b4551c2381828b256608d2c6ced3ae745
> src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
>
>
> Diff: https://reviews.apache.org/r/65585/diff/5/
>
>
> Testing
> -------
>
> On Fedora 25:
> ```
> apache-mesos (MESOS-8240)$ cd src/python/cli_new/
> cli_new (MESOS-8240)$ ./bootstrap
> cli_new (MESOS-8240)$ source .virtualenv/activate
> (mesos-cli) cli_new (MESOS-8240)$ mesos
> Mesos CLI
>
> Usage:
> mesos (-h | --help)
> mesos --version
> mesos <command> [<args>...]
>
> Options:
> -h --help Show this screen.
> --version Show version info.
>
> Commands:
> agent Interacts with the Mesos agents
> config Interacts with the Mesos CLI configuration file
> task Interacts with the tasks running in a Mesos cluster
>
> See 'mesos help <command>' for more information on a specific command.
> (mesos-cli) cli_new (MESOS-8240)$ source deactivate
> cli_new (MESOS-8240)$ rm -rf .virtualenv/
> cli_new (MESOS-8240)$ cd ..
> python (MESOS-8240)$ VIRTUALENV_DIRECTORY=$(pwd)/.venv ./cli_new/bootstrap
> python (MESOS-8240)$ source /home/agrillet/apache-mesos/src/python/.venv/bin/activate
> python (MESOS-8240)$ source /home/agrillet/apache-mesos/src/python/.venv/bin/postactivate
> (mesos-cli) python (MESOS-8240)$ mesos
> Mesos CLI
>
> Usage:
> mesos (-h | --help)
> mesos --version
> mesos <command> [<args>...]
>
> Options:
> -h --help Show this screen.
> --version Show version info.
>
> Commands:
> agent Interacts with the Mesos agents
> config Interacts with the Mesos CLI configuration file
> task Interacts with the tasks running in a Mesos cluster
>
> See 'mesos help <command>' for more information on a specific command.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65585: Improved documentation regarding the new
CLI setup.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65585/#review200999
-----------------------------------------------------------
src/python/cli_new/README.md
Lines 40-55 (patched)
<https://reviews.apache.org/r/65585/#comment281931>
I am going to change this to "~/.mesos-cli-venv" before I commit it.
src/python/cli_new/bin/mesos
Line 5 (original)
<https://reviews.apache.org/r/65585/#comment281932>
This should probably have been in a spearate commit since it's a functionality change and not just documentation.
src/python/cli_new/bin/mesos-cli-tests
Line 5 (original)
<https://reviews.apache.org/r/65585/#comment281933>
This should probably have been in a spearate commit since it's a functionality change and not just documentation.
- Kevin Klues
On April 12, 2018, 12:36 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65585/
> -----------------------------------------------------------
>
> (Updated April 12, 2018, 12:36 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Kevin Klues.
>
>
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Explains how to create the necessary virtual environment from
> anywhere and how to set up autocompletion in such case.
>
> Also removes an unnecessary activation of the virtual environment
> in `mesos` and `mesos-cli-tests`.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md 847141db9a1f9eb5c78b2d50367b599a5c72ce61
> src/python/cli_new/bin/mesos c5152a2ebf8704c804bb4f39e46580a512aecdea
> src/python/cli_new/bin/mesos-cli-tests 07659e0b4551c2381828b256608d2c6ced3ae745
> src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
>
>
> Diff: https://reviews.apache.org/r/65585/diff/6/
>
>
> Testing
> -------
>
> On Fedora 25:
> ```
> apache-mesos (MESOS-8240)$ cd src/python/cli_new/
> cli_new (MESOS-8240)$ ./bootstrap
> cli_new (MESOS-8240)$ source .virtualenv/activate
> (mesos-cli) cli_new (MESOS-8240)$ mesos
> Mesos CLI
>
> Usage:
> mesos (-h | --help)
> mesos --version
> mesos <command> [<args>...]
>
> Options:
> -h --help Show this screen.
> --version Show version info.
>
> Commands:
> agent Interacts with the Mesos agents
> config Interacts with the Mesos CLI configuration file
> task Interacts with the tasks running in a Mesos cluster
>
> See 'mesos help <command>' for more information on a specific command.
> (mesos-cli) cli_new (MESOS-8240)$ source deactivate
> cli_new (MESOS-8240)$ rm -rf .virtualenv/
> cli_new (MESOS-8240)$ cd ..
> python (MESOS-8240)$ VIRTUALENV_DIRECTORY=$(pwd)/.venv ./cli_new/bootstrap
> python (MESOS-8240)$ source /home/agrillet/apache-mesos/src/python/.venv/bin/activate
> python (MESOS-8240)$ source /home/agrillet/apache-mesos/src/python/.venv/bin/postactivate
> (mesos-cli) python (MESOS-8240)$ mesos
> Mesos CLI
>
> Usage:
> mesos (-h | --help)
> mesos --version
> mesos <command> [<args>...]
>
> Options:
> -h --help Show this screen.
> --version Show version info.
>
> Commands:
> agent Interacts with the Mesos agents
> config Interacts with the Mesos CLI configuration file
> task Interacts with the tasks running in a Mesos cluster
>
> See 'mesos help <command>' for more information on a specific command.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65585: Improved documentation regarding the new
CLI setup.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65585/
-----------------------------------------------------------
(Updated April 12, 2018, 12:36 p.m.)
Review request for mesos, Benjamin Bannier and Kevin Klues.
Changes
-------
Fixed issues.
Bugs: MESOS-8240
https://issues.apache.org/jira/browse/MESOS-8240
Repository: mesos
Description
-------
Explains how to create the necessary virtual environment from
anywhere and how to set up autocompletion in such case.
Also removes an unnecessary activation of the virtual environment
in `mesos` and `mesos-cli-tests`.
Diffs (updated)
-----
src/python/cli_new/README.md 847141db9a1f9eb5c78b2d50367b599a5c72ce61
src/python/cli_new/bin/mesos c5152a2ebf8704c804bb4f39e46580a512aecdea
src/python/cli_new/bin/mesos-cli-tests 07659e0b4551c2381828b256608d2c6ced3ae745
src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
Diff: https://reviews.apache.org/r/65585/diff/6/
Changes: https://reviews.apache.org/r/65585/diff/5-6/
Testing
-------
On Fedora 25:
```
apache-mesos (MESOS-8240)$ cd src/python/cli_new/
cli_new (MESOS-8240)$ ./bootstrap
cli_new (MESOS-8240)$ source .virtualenv/activate
(mesos-cli) cli_new (MESOS-8240)$ mesos
Mesos CLI
Usage:
mesos (-h | --help)
mesos --version
mesos <command> [<args>...]
Options:
-h --help Show this screen.
--version Show version info.
Commands:
agent Interacts with the Mesos agents
config Interacts with the Mesos CLI configuration file
task Interacts with the tasks running in a Mesos cluster
See 'mesos help <command>' for more information on a specific command.
(mesos-cli) cli_new (MESOS-8240)$ source deactivate
cli_new (MESOS-8240)$ rm -rf .virtualenv/
cli_new (MESOS-8240)$ cd ..
python (MESOS-8240)$ VIRTUALENV_DIRECTORY=$(pwd)/.venv ./cli_new/bootstrap
python (MESOS-8240)$ source /home/agrillet/apache-mesos/src/python/.venv/bin/activate
python (MESOS-8240)$ source /home/agrillet/apache-mesos/src/python/.venv/bin/postactivate
(mesos-cli) python (MESOS-8240)$ mesos
Mesos CLI
Usage:
mesos (-h | --help)
mesos --version
mesos <command> [<args>...]
Options:
-h --help Show this screen.
--version Show version info.
Commands:
agent Interacts with the Mesos agents
config Interacts with the Mesos CLI configuration file
task Interacts with the tasks running in a Mesos cluster
See 'mesos help <command>' for more information on a specific command.
```
Thanks,
Armand Grillet