[GitHub] [druid] abhagraw commented on a diff in pull request #13660: Support both Indexer and MiddleManager in ITs

[GitBox <gi...@apache.org>]

abhagraw commented on code in PR #13660:
URL: https://github.com/apache/druid/pull/13660#discussion_r1068965566


##########
integration-tests-ex/docs/guide.md:
##########
@@ -239,3 +239,29 @@ test. Your test will run in parallel with all other IT categories, which is why
 we offered the advice above: the test has to have a good reason to fire up yet
 another build task.
 
+### Choosing the Middle Manager or Indexer
+
+Tests should run on the Middle Manager by default. Tests can optionally runn on the
+Indexer. To run on Indexer:
+
+* In the environment, `export DRUID_INTEGRATION_TEST_INDEXER=indexer`. (Use `middleManager`
+  otherwise. If the variable is not set, `middleManager` is the default.)
+* The `cluster/<category>/docker-compose.yaml` file should be for the Middle manager. Create
+  a separate file called `cluster/<category>/docker-compose-indexer.yaml` to define the
+  Indexer-based cluster.
+* The test `src/test/resources/cluster/<category>/docker.yaml` file should contain a conditional

Review Comment:
   @paul-rogers As I understand the above question - 
   Say we have 10 tests in the `MSQ` category - 9 of them run for both MM and indexer and one test only runs on MM.
   For that one test - do we need to create a new category (which only has `docker-compose.yaml` file) or can we have the option to skip it when the tests MSQ category tests run with indexer?
   
   Both `docker-compose.yaml` and `docker-compose-indexer.yaml` will be present as the other tests in the category need it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org