[GitHub] [skywalking] dagmom commented on a change in pull request #5156: Support alarm labels

[GitBox <gi...@apache.org>]

dagmom commented on a change in pull request #5156:
URL: https://github.com/apache/skywalking/pull/5156#discussion_r460471370



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/alarm/AlarmRecord.java
##########
@@ -64,6 +66,8 @@ public String id() {
     private long startTime;
     @Column(columnName = ALARM_MESSAGE, matchQuery = true)
     private String alarmMessage;
+    @Column(columnName = LABELS, matchQuery = true)
+    private String labels;

Review comment:
       I'm not going to modify UI, just store data.
   I've just read the code about `@ Column` in other persistent scenario.
   
   ```java
   @Column(columnName = LABELS, dataType = Column.ValueDataType.LABELED_VALUE)
   private DataTable labels;
   ```
   
   Is that more appropriate? But I have a question, how to search by the specified label(key=value)？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org