You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eumiro (via GitHub)" <gi...@apache.org> on 2023/08/22 18:42:50 UTC
[GitHub] [airflow] eumiro opened a new pull request, #33624: Suggestion: Format screen output to 79 chars
eumiro opened a new pull request, #33624:
URL: https://github.com/apache/airflow/pull/33624
This is just to see what you'd tell to a more aligned formatting of screen output. There are a few other places in the code that could be converted to this as well. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suggestion: Format screen output to 79 chars [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #33624: Suggestion: Format screen output to 79 chars
URL: https://github.com/apache/airflow/pull/33624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33624: Suggestion: Format screen output to 79 chars
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33624:
URL: https://github.com/apache/airflow/pull/33624#discussion_r1304109668
##########
dev/breeze/src/airflow_breeze/utils/docs_errors.py:
##########
@@ -61,15 +61,15 @@ def __lt__(self, right):
def display_errors_summary(build_errors: dict[str, list[DocBuildError]]) -> None:
"""Displays summary of errors"""
console.print()
- console.print("[red]" + "#" * 30 + " Start docs build errors summary " + "#" * 30 + "[/]")
+ console.print("[red]" + " Start docs build errors summary ".center(79, "#") + "[/]")
Review Comment:
Should not we change CONSOLE_WIDTH instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suggestion: Format screen output to 79 chars [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33624:
URL: https://github.com/apache/airflow/pull/33624#issuecomment-1752202169
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #33624: Suggestion: Format screen output to 79 chars
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #33624:
URL: https://github.com/apache/airflow/pull/33624#discussion_r1304111251
##########
dev/breeze/src/airflow_breeze/utils/docs_errors.py:
##########
@@ -61,15 +61,15 @@ def __lt__(self, right):
def display_errors_summary(build_errors: dict[str, list[DocBuildError]]) -> None:
"""Displays summary of errors"""
console.print()
- console.print("[red]" + "#" * 30 + " Start docs build errors summary " + "#" * 30 + "[/]")
+ console.print("[red]" + " Start docs build errors summary ".center(79, "#") + "[/]")
Review Comment:
Or maybe not. We have sometimes much longer messages .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33624: Suggestion: Format screen output to 79 chars
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33624:
URL: https://github.com/apache/airflow/pull/33624#issuecomment-1691406705
Do you have screenshot before / after maybe :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org