[GitHub] [samza] rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention

[GitBox <gi...@apache.org>]

rmatharu commented on a change in pull request #980: Cleaned up AM logs and naming convention
URL: https://github.com/apache/samza/pull/980#discussion_r270496794
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java
 ##########
 @@ -33,16 +33,13 @@
 
 /**
  * {@link AbstractContainerAllocator} makes requests for physical resources to the resource manager and also runs
- * a container process on an allocated physical resource. Sub-classes should override the assignResourceRequests()
+ * a processor on an allocated physical resource. Sub-classes should override the assignResourceRequests()
  * method to assign resource requests according to some strategy.
  *
  * See {@link ContainerAllocator} and {@link HostAwareContainerAllocator} for two such strategies
  *
- * This class is not thread-safe.
+ * This class is not thread-safe. This class is used in the refactored code path as called by run-jc.sh
 
 Review comment:
   Maybe update this, until we delete the AbstractContainerAllocator.
   // This class is instantiated by the ContainerProcessManager (which inturn is created by the JC from run-jc.sh), when host-affinity is off. Otherwise, the HostAwareContainerAllocator is instantiated.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services