You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2021/04/20 08:08:15 UTC
[GitHub] [isis] andi-huber opened a new pull request #505: 2617 wicketstuff.bs4
andi-huber opened a new pull request #505:
URL: https://github.com/apache/isis/pull/505
1. - [ ] Table style dropdown
2. - [ ] Action Dropdown
3. - [ ] Trees
4. - [ ] Right Label Position (also broken in M5 - so no worries)
5. - [ ] Disabled Actions (strange style)
6. - [ ] Where's the default Flatly color gone?
7. - [ ] Table Paging Support
8. - [ ] DateTime picker on empty field, has the browser interfere using autocompletion (seen on firefox)
9. - [ ] Responsive design behavior of main menu got lost
10. - [ ] Reasess ISIS-2390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
andi-huber commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r618437847
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/serviceactions/ServiceActionsPanel.java
##########
@@ -38,7 +38,7 @@
import lombok.val;
-import de.agilecoders.wicket.extensions.markup.html.bootstrap.button.DropdownAutoOpenJavaScriptReference;
+// import de.agilecoders.wicket.extensions.markup.html.bootstrap.button.DropdownAutoOpenJavaScriptReference;
Review comment:
change of behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] mwhesse commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r618847225
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/serviceactions/ServiceActionsPanel.java
##########
@@ -38,7 +38,7 @@
import lombok.val;
-import de.agilecoders.wicket.extensions.markup.html.bootstrap.button.DropdownAutoOpenJavaScriptReference;
+// import de.agilecoders.wicket.extensions.markup.html.bootstrap.button.DropdownAutoOpenJavaScriptReference;
Review comment:
Was not available via wicketstuff anymore after the upgrade, will have to see if this is available directly in boostrap or find another library/approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] mwhesse commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r619650965
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/serviceactions/ServiceActionsPanel.java
##########
@@ -38,7 +38,7 @@
import lombok.val;
-import de.agilecoders.wicket.extensions.markup.html.bootstrap.button.DropdownAutoOpenJavaScriptReference;
+// import de.agilecoders.wicket.extensions.markup.html.bootstrap.button.DropdownAutoOpenJavaScriptReference;
Review comment:
New behavior is now contributed here:
https://github.com/apache/isis/commit/f614ca4b9630ae08c898af09bb0be1d0326b3f29#diff-6f57cd3d3471edc5af13ddad17e104d475605809bc48e744135d85f157605c46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] mwhesse commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r616938069
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/bootstrap-overrides-all-v2.css
##########
@@ -25,30 +25,34 @@
}
#body {
- padding-top: 0px;
+ padding-top: 61px;
Review comment:
Yeah... the fixed-top class is the culprit right now, don't know how to address it otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
andi-huber commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r618442742
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/util/ExtendedPopoverConfig.java
##########
@@ -0,0 +1,31 @@
+package org.apache.isis.viewer.wicket.ui.util;
Review comment:
license header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] mwhesse commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r616924229
##########
File path: examples/demo/wicket/src/main/java/demoapp/webapp/wicket/DemoAppWicket.java
##########
@@ -72,7 +73,7 @@
* entry point by searching for classes having a {@code main(...)}
*/
public static void main(String[] args) {
- //IsisPresets.prototyping();
+ IsisPresets.prototyping();
Review comment:
comment back in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] mwhesse commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r616926032
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/bootstrap-overrides-all-v2.css
##########
@@ -25,30 +25,34 @@
}
#body {
- padding-top: 0px;
+ padding-top: 61px;
Review comment:
Not sure this covers all the cases, but looks ok for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] mwhesse commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r618846713
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/bootstrap-overrides-all-v2.css
##########
@@ -25,30 +25,34 @@
}
#body {
- padding-top: 0px;
+ padding-top: 61px;
Review comment:
I looked up some examples on bootswatch and they seem to be adding 120px top-padding in their custom CSS for the theme demos:
https://bootswatch.com/_assets/css/custom.min.css
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] mwhesse commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r619650965
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/serviceactions/ServiceActionsPanel.java
##########
@@ -38,7 +38,7 @@
import lombok.val;
-import de.agilecoders.wicket.extensions.markup.html.bootstrap.button.DropdownAutoOpenJavaScriptReference;
+// import de.agilecoders.wicket.extensions.markup.html.bootstrap.button.DropdownAutoOpenJavaScriptReference;
Review comment:
New behavior is now contributed here:
https://github.com/apache/isis/commit/f614ca4b9630ae08c898af09bb0be1d0326b3f29#diff-6f57cd3d3471edc5af13ddad17e104d475605809bc48e744135d85f157605c46
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/serviceactions/ServiceActionsPanel.java
##########
@@ -83,8 +83,8 @@ public void renderHead(IHeaderResponse response) {
response.render(CssHeaderItem.forReference(new CssResourceReference(ServiceActionsPanel.class, "ServiceActionsPanel.css")));
Tooltips.renderHead(response);
- response.render(JavaScriptHeaderItem.forReference(DropdownAutoOpenJavaScriptReference.instance()));
- response.render(OnDomReadyHeaderItem.forScript("$('.dropdown-toggle').dropdownHover();"));
+ // response.render(JavaScriptHeaderItem.forReference(DropdownAutoOpenJavaScriptReference.instance()));
Review comment:
Can be removed
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/datepicker/TextFieldWithDateTimePicker.java
##########
@@ -91,7 +91,12 @@ public TextFieldWithDateTimePicker(
config.minDate(datePickerMinDate);
config.maxDate(datePickerMaxDate);
-
+
+ boolean enabled = this.isEnabled();
+
+ // config.keepOpen(true);
Review comment:
remove this line
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.java
##########
@@ -47,8 +47,8 @@
import de.agilecoders.wicket.themes.markup.html.bootstrap.BootstrapThemeTheme;
import de.agilecoders.wicket.themes.markup.html.bootswatch.BootswatchTheme;
import de.agilecoders.wicket.themes.markup.html.bootswatch.BootswatchThemeProvider;
-import de.agilecoders.wicket.themes.markup.html.vegibit.VegibitTheme;
-import de.agilecoders.wicket.themes.markup.html.vegibit.VegibitThemeProvider;
+// import de.agilecoders.wicket.themes.markup.html.vegibit.VegibitTheme;
Review comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
andi-huber commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r616930846
##########
File path: examples/demo/wicket/src/main/java/demoapp/webapp/wicket/DemoAppWicket.java
##########
@@ -72,7 +73,7 @@
* entry point by searching for classes having a {@code main(...)}
*/
public static void main(String[] args) {
- //IsisPresets.prototyping();
+ IsisPresets.prototyping();
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber merged pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
andi-huber merged pull request #505:
URL: https://github.com/apache/isis/pull/505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] mwhesse commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r619650984
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/serviceactions/ServiceActionsPanel.java
##########
@@ -83,8 +83,8 @@ public void renderHead(IHeaderResponse response) {
response.render(CssHeaderItem.forReference(new CssResourceReference(ServiceActionsPanel.class, "ServiceActionsPanel.css")));
Tooltips.renderHead(response);
- response.render(JavaScriptHeaderItem.forReference(DropdownAutoOpenJavaScriptReference.instance()));
- response.render(OnDomReadyHeaderItem.forScript("$('.dropdown-toggle').dropdownHover();"));
+ // response.render(JavaScriptHeaderItem.forReference(DropdownAutoOpenJavaScriptReference.instance()));
Review comment:
Can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] mwhesse commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r619651206
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.java
##########
@@ -47,8 +47,8 @@
import de.agilecoders.wicket.themes.markup.html.bootstrap.BootstrapThemeTheme;
import de.agilecoders.wicket.themes.markup.html.bootswatch.BootswatchTheme;
import de.agilecoders.wicket.themes.markup.html.bootswatch.BootswatchThemeProvider;
-import de.agilecoders.wicket.themes.markup.html.vegibit.VegibitTheme;
-import de.agilecoders.wicket.themes.markup.html.vegibit.VegibitThemeProvider;
+// import de.agilecoders.wicket.themes.markup.html.vegibit.VegibitTheme;
Review comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] mwhesse commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
mwhesse commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r619651081
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/datepicker/TextFieldWithDateTimePicker.java
##########
@@ -91,7 +91,12 @@ public TextFieldWithDateTimePicker(
config.minDate(datePickerMinDate);
config.maxDate(datePickerMaxDate);
-
+
+ boolean enabled = this.isEnabled();
+
+ // config.keepOpen(true);
Review comment:
remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on a change in pull request #505: 2617 wicketstuff.bs4
Posted by GitBox <gi...@apache.org>.
andi-huber commented on a change in pull request #505:
URL: https://github.com/apache/isis/pull/505#discussion_r616932206
##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/bootstrap-overrides-all-v2.css
##########
@@ -25,30 +25,34 @@
}
#body {
- padding-top: 0px;
+ padding-top: 61px;
Review comment:
Without knowing any context, seems it would be cool if we don't need that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org