You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/10 06:15:25 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #38589: [SPARK-41087][BUILD] Make `build/mvn` use the same JAVA_OPTS as `dev/make-distribution.sh`

LuciferYang commented on code in PR #38589:
URL: https://github.com/apache/spark/pull/38589#discussion_r1018690310


##########
build/mvn:
##########
@@ -36,7 +36,7 @@ _DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 # Preserve the calling directory
 _CALLING_DIR="$(pwd)"
 # Options used during compilation
-_COMPILE_JVM_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g -Xss128m"
+_COMPILE_JVM_OPTS="-Xss128m -Xmx4g -Xmx4g -XX:ReservedCodeCacheSize=128m"

Review Comment:
   Sorry, it copy from 
   
   https://github.com/apache/spark/blob/865a3ded2ea1ca86be93df58205882bc509b98cd/dev/make-distribution.sh#L164
   
   do you mind also remove the dup `-Xmx4g` from `make-distribution.sh` in this pr?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org