You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org> on 2008/05/01 18:52:55 UTC

[jira] Created: (TUSCANY-2286) Add vtest for @Init annotation

Add vtest for @Init annotation
------------------------------

                 Key: TUSCANY-2286
                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
             Project: Tuscany
          Issue Type: Test
          Components: Java SCA Verification Tests
            Reporter: Vamsavardhana Reddy
             Fix For: Java-SCA-Next


Add verification tests for @Init annotation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Kevin Williams (JIRA)" <tu...@ws.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594329#action_12594329 ] 

Kevin Williams commented on TUSCANY-2286:
-----------------------------------------

I applied the latest patch OK but there is no associated test case.  I assume you did not intend this.

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286-2.patch, TUSCANY-2286-3.patch, TUSCANY-2286-final.patch, TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy updated TUSCANY-2286:
-----------------------------------------

    Description: 
Add verification tests for @Init annotation.

Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
1291 the local service implemented by the class starts. The method must have a void return value and no
1292 arguments. The annotated method must be public. The annotated method is called after all property and
1293 reference injection is complete.

  was:Add verification tests for @Init annotation.

     Patch Info: [Patch Available]

Marking patch available.  Unassigning so that a committer can pickup.

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>            Assignee: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy reassigned TUSCANY-2286:
--------------------------------------------

    Assignee: Vamsavardhana Reddy

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>            Assignee: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>
> Add verification tests for @Init annotation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy updated TUSCANY-2286:
-----------------------------------------

    Attachment: TUSCANY-2286-final.patch

TUSCANY-2286-final.patch: Fixed the service names and component names as per the convention followed in other vtests.  Use this patch alone and ignore all other patches.

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>            Assignee: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286-2.patch, TUSCANY-2286-3.patch, TUSCANY-2286-final.patch, TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy updated TUSCANY-2286:
-----------------------------------------

    Attachment: TUSCANY-2286.patch

TUSCANY-2286.patch: Added tests for the following scenarios.

1. Proper init method is called after all properties and references are injected.
2. Error to annotate a protected method with @Init
3. Error to annotate a private method with @Init
4. Error to annotate a method with a non-void return type with @Init
5. Error to annotate a method with arguments with @Init

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>            Assignee: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy reassigned TUSCANY-2286:
--------------------------------------------

    Assignee:     (was: Vamsavardhana Reddy)

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286-2.patch, TUSCANY-2286-3.patch, TUSCANY-2286-final.patch, TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy updated TUSCANY-2286:
-----------------------------------------

    Attachment: TUSCANY-2286-3.patch

TUSCANY-2286-3.patch: I have added the javadoc comments for each of the test methods.  Please ignore the other two patches.

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>            Assignee: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286-2.patch, TUSCANY-2286-3.patch, TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy updated TUSCANY-2286:
-----------------------------------------

    Attachment: TUSCANY-2286-2.patch

TUSCANY-2286-2.patch: Please try to apply this patch through tortoisesvn and let me know is the error still occurs.

"conventions for service names and components and test structure" <= I appreciate if you can explain a little more about this.  Thanks.

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>            Assignee: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286-2.patch, TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Kevin Williams (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Williams closed TUSCANY-2286.
-----------------------------------

    Resolution: Fixed

I am closing this but would like to see the test case converted to use the SCADomain APIs from the test client to locate the services under test.

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286-2.patch, TUSCANY-2286-3.patch, TUSCANY-2286-final.patch, TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594332#action_12594332 ] 

Vamsavardhana Reddy commented on TUSCANY-2286:
----------------------------------------------

Must have removed it by mistake while creating the patch.  Posted a new patch with the same name TUSCANY-2286-final.patch.  I hope it is really final this time :)

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286-2.patch, TUSCANY-2286-3.patch, TUSCANY-2286-final.patch, TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy updated TUSCANY-2286:
-----------------------------------------

    Attachment: TUSCANY-2286-final.patch

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286-2.patch, TUSCANY-2286-3.patch, TUSCANY-2286-final.patch, TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Kevin Williams (JIRA)" <tu...@ws.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593632#action_12593632 ] 

Kevin Williams commented on TUSCANY-2286:
-----------------------------------------

Thanks for contributing this test for the @init annotation. 

Unfortunately, I am unable to apply your patch file.  The error I get (using TortiseSVN) is :

"An unknown line type was found in line 51!"  This may have to do with the inclusion of property changes in the patch.

I did take a scan through the content and wonder if you could make changes to your patch to be more consistent with the existing tests.? We have been using conventions for service names and components and test structure and I hope to keep this consistent throughout the bucket.   We have also been using a javadoc convention on the test cases to explicitly call out the specification line numbers that each test addresses.

Thanks again!

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>            Assignee: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TUSCANY-2286) Add vtest for @Init annotation

Posted by "Vamsavardhana Reddy (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vamsavardhana Reddy updated TUSCANY-2286:
-----------------------------------------

    Attachment:     (was: TUSCANY-2286-final.patch)

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286-2.patch, TUSCANY-2286-3.patch, TUSCANY-2286-final.patch, TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.