[GitHub] [pulsar] alpreu commented on a diff in pull request #19004: [improve][io] Debezium sources: Support loading config from secrets

[GitBox <gi...@apache.org>]

alpreu commented on code in PR #19004:
URL: https://github.com/apache/pulsar/pull/19004#discussion_r1054386245


##########
pulsar-io/debezium/core/src/main/java/org/apache/pulsar/io/debezium/DebeziumSource.java:
##########
@@ -60,11 +62,24 @@ public static String topicNamespace(SourceContext sourceContext) {
                 + (StringUtils.isEmpty(namespace) ? TopicName.DEFAULT_NAMESPACE : namespace);
     }
 
+    public static void tryLoadingConfigSecret(String secretName, Map<String, Object> config, SourceContext context) {
+        try {
+            String secret = context.getSecret(secretName);
+            if (secret != null) {
+                config.put(secretName, secret);

Review Comment:
   Good point, added!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org