[GitHub] [spark] mridulm commented on a change in pull request #31992: [SPARK-34898][CORE] We should send SparkListenerExecutorMetricsUpdateEventLog of `driver` appropriately

[GitBox <gi...@apache.org>]

mridulm commented on a change in pull request #31992:
URL: https://github.com/apache/spark/pull/31992#discussion_r607236171



##########
File path: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala
##########
@@ -249,6 +249,9 @@ private[spark] class EventLoggingListener(
   }
 
   override def onExecutorMetricsUpdate(event: SparkListenerExecutorMetricsUpdate): Unit = {
+    if (event.execId == SparkContext.DRIVER_IDENTIFIER) {
+      logEvent(event)
+    }

Review comment:
       Currently, we have a single event for both driver and executor metrics update - differentiated by exec id.
   I dont have strong opinions on this, but if we have a flag (`shouldLogStageExecutorMetrics`) controlling whether metrics are to be updated, we should consistently apply it IMO.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org