You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/04/19 09:37:01 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #1439: [CELEBORN-530][REFACTOR] Move stream manager and memory manager to worker module.
FMX opened a new pull request, #1439:
URL: https://github.com/apache/incubator-celeborn/pull/1439
### What changes were proposed in this pull request?
To move stream manager and memory manager to the worker module thus those code is only needed by worker.
### Why are the changes needed?
Those codes should not be in the common module and shipped to the client.
### Does this PR introduce _any_ user-facing change?
NO.
### How was this patch tested?
UT and cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1439: [CELEBORN-530][REFACTOR] Move stream manager and memory manager to worker module.
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1439:
URL: https://github.com/apache/incubator-celeborn/pull/1439#discussion_r1172011939
##########
common/src/main/java/org/apache/celeborn/common/util/JavaUtils.java:
##########
@@ -462,4 +464,24 @@ public V computeIfAbsent(K key, Function<? super K, ? extends V> mappingFunction
return result;
}
}
+
+ public static void timeOutOrMeetCondition(Callable<Boolean> callable) throws Exception {
Review Comment:
nit: I think it's better to pass ```timeout``` as a parameter to be more flexible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1439: [CELEBORN-530][REFACTOR] Move stream manager and memory manager to worker module.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1439:
URL: https://github.com/apache/incubator-celeborn/pull/1439#issuecomment-1514509724
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1439?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1439](https://codecov.io/gh/apache/incubator-celeborn/pull/1439?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26859a8) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/7937d96226810f25e37f7e91ab4bf9aa70888339?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7937d96) will **decrease** coverage by `0.82%`.
> The diff coverage is `60.00%`.
```diff
@@ Coverage Diff @@
## main #1439 +/- ##
==========================================
- Coverage 45.70% 44.88% -0.82%
==========================================
Files 167 156 -11
Lines 10531 9572 -959
Branches 1044 956 -88
==========================================
- Hits 4812 4295 -517
+ Misses 5385 4996 -389
+ Partials 334 281 -53
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1439?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/celeborn/common/util/JavaUtils.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1439?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vdXRpbC9KYXZhVXRpbHMuamF2YQ==) | `45.82% <55.56%> (+0.52%)` | :arrow_up: |
| [...ache/celeborn/common/network/TransportContext.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1439?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9UcmFuc3BvcnRDb250ZXh0LmphdmE=) | `81.58% <100.00%> (ø)` | |
... and [13 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1439/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1439: [CELEBORN-530][REFACTOR] Move stream manager and memory manager to worker module.
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1439:
URL: https://github.com/apache/incubator-celeborn/pull/1439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org