You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/02/14 14:07:42 UTC
[GitHub] [submarine] FatalLin opened a new pull request #878: SUBMARINE-1187. Refine the interface of internal service and keep more details into db
FatalLin opened a new pull request #878:
URL: https://github.com/apache/submarine/pull/878
### What is this PR for?
per discussion with @pingsutw, we would like to persist more detail data into database which allow us to provide to users when they check the detail, therefore I refine the logic when handler receiving the events, it will align the same logic in k8ssubmitter to rebuild the corresponding object, and pass to internal service, then the internal service persist it into database.
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1187
### How should this be tested?
existed unit tests.
### Screenshots (if appropriate)
same of: https://github.com/apache/submarine/pull/877
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #878: SUBMARINE-1187. Refine the interface of internal service and keep more details into db
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #878:
URL: https://github.com/apache/submarine/pull/878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] FatalLin commented on a change in pull request #878: SUBMARINE-1187. Refine the interface of internal service and keep more details into db
Posted by GitBox <gi...@apache.org>.
FatalLin commented on a change in pull request #878:
URL: https://github.com/apache/submarine/pull/878#discussion_r808163700
##########
File path: submarine-server/server-core/pom.xml
##########
@@ -437,6 +437,11 @@
<artifactId>jackson-annotations</artifactId>
</exclusion>
</exclusions>
+ </dependency>
+ <dependency>
+ <groupId>joda-time</groupId>
+ <artifactId>joda-time</artifactId>
+ <version>2.10.8</version>
Review comment:
@jiwq thanks for the comments!
Just want to make to make sure what's the center management you mentioned, the root pom.xml?
I leave the dependency here because this is only the place I need to align the same time format from k8s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] FatalLin commented on a change in pull request #878: SUBMARINE-1187. Refine the interface of internal service and keep more details into db
Posted by GitBox <gi...@apache.org>.
FatalLin commented on a change in pull request #878:
URL: https://github.com/apache/submarine/pull/878#discussion_r808169616
##########
File path: submarine-server/server-core/pom.xml
##########
@@ -437,6 +437,11 @@
<artifactId>jackson-annotations</artifactId>
</exclusion>
</exclusions>
+ </dependency>
+ <dependency>
+ <groupId>joda-time</groupId>
+ <artifactId>joda-time</artifactId>
+ <version>2.10.8</version>
Review comment:
yeah, I think that's the place. the polish code has been committed, thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jiwq commented on a change in pull request #878: SUBMARINE-1187. Refine the interface of internal service and keep more details into db
Posted by GitBox <gi...@apache.org>.
jiwq commented on a change in pull request #878:
URL: https://github.com/apache/submarine/pull/878#discussion_r808143115
##########
File path: submarine-server/server-core/pom.xml
##########
@@ -437,6 +437,11 @@
<artifactId>jackson-annotations</artifactId>
</exclusion>
</exclusions>
+ </dependency>
+ <dependency>
Review comment:
indentation nit~
##########
File path: submarine-server/server-core/pom.xml
##########
@@ -437,6 +437,11 @@
<artifactId>jackson-annotations</artifactId>
</exclusion>
</exclusions>
+ </dependency>
+ <dependency>
+ <groupId>joda-time</groupId>
+ <artifactId>joda-time</artifactId>
+ <version>2.10.8</version>
Review comment:
- should better move the dependency to center management
- the artifact's version should define in property
##########
File path: submarine-server/server-core/src/main/java/org/apache/submarine/server/experiment/database/entity/ExperimentEntity.java
##########
@@ -19,6 +19,7 @@
package org.apache.submarine.server.experiment.database.entity;
+
Review comment:
redundant blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org