[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32830: [SPARK-32975][K8S][FOLLOWUP] Avoid None.get exception

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #32830:
URL: https://github.com/apache/spark/pull/32830#discussion_r648008292



##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala
##########
@@ -647,6 +647,19 @@ class ExecutorPodsAllocatorSuite extends SparkFunSuite with BeforeAndAfter {
     verify(persistentVolumeClaims, never()).create(any())
   }
 
+  test("SPARK-32975: Avoid None.get when KUBERNETES_DRIVER_POD_NAME is option for client mode") {
+    val msg = "None.get"
+    val logAppender = new LogAppender(msg)
+    withLogAppender(logAppender) {
+      val conf = new SparkConf().remove(KUBERNETES_DRIVER_POD_NAME)

Review comment:
       Do we need this for optional conf?
   ```scala
     val KUBERNETES_DRIVER_POD_NAME =
       ConfigBuilder("spark.kubernetes.driver.pod.name")
         .doc("Name of the driver pod.")
         .version("2.3.0")
         .stringConf
         .createOptional
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org