You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hector Acosta (Code Review)" <ge...@cloudera.org> on 2019/03/12 15:53:33 UTC

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12724


Change subject: Add missing sudo call to `service postgresql start`
......................................................................

Add missing sudo call to `service postgresql start`

Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
---
M bin/bootstrap_system.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12724/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2445/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 21:06:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3908/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 17:58:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 16:08:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................


Patch Set 1: Code-Review+1

Makes sense.


-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 16:40:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................

Add missing sudo call to `service postgresql start`

Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Reviewed-on: http://gerrit.cloudera.org:8080/12724
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_system.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3956/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Mar 2019 14:09:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Mar 2019 18:37:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 22:31:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................

Add missing sudo call to `service postgresql start`

Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
---
M bin/bootstrap_system.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12724/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................


Patch Set 2: Code-Review+2

Carry +2


-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 00:27:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 )

Change subject: Add missing sudo call to `service postgresql start`
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2412/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3859ad1308b7cd1d483d043b9f71d9f95abdf75
Gerrit-Change-Number: 12724
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 16:37:20 +0000
Gerrit-HasComments: No