[GitHub] alikemalocalan commented on a change in pull request #4494: [AIRFLOW-3284] Azure Batch AI Operator

[GitBox <gi...@apache.org>]

alikemalocalan commented on a change in pull request #4494: [AIRFLOW-3284] Azure Batch AI Operator
URL: https://github.com/apache/airflow/pull/4494#discussion_r249418220
 
 

 ##########
 File path: airflow/utils/db.py
 ##########
 @@ -280,6 +280,14 @@ def initdb(rbac=False):
         Connection(
             conn_id='azure_cosmos_default', conn_type='azure_cosmos',
             extra='{"database_name": "<DATABASE_NAME>", "collection_name": "<COLLECTION_NAME>" }'))
+    merge_conn(
 
 Review comment:
   Hi @mik-laj , i have this same problem. Because Azure usually uses ```ServicePrincipalCredentials``` and other optional auth(like DB name or rest username/pass). 
   My suggestion is creating uniform connection like GCP and it should only include ```ServicePrincipalCredentials``` from auth file, Other credentials(like username/pass for optional) should be in extras.
   That way we can use ```azure_default ```.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services