You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jsmucr (via GitHub)" <gi...@apache.org> on 2023/08/15 07:20:14 UTC
[GitHub] [activemq-artemis] jsmucr opened a new pull request, #4578: Fix upgrade-linux smoke test on Windows
jsmucr opened a new pull request, #4578:
URL: https://github.com/apache/activemq-artemis/pull/4578
The test cannot work on Windows unless I can make the `upgrade` CLI command respect my choice to upgrade a Linux distribution. This commit therefore adds a new `--linux` option for the `upgrade` command, and leverages it in the `upgrade-linux` smoke test.
* The `--cygwin` option has been preserved for backwards compatibility.
* The `IS_CYGWIN` attribute has been renamed to `IS_NIX` to reflect the change.
* The OS "recognition" method (in `InstallAbstract::run`) has been updated to reflect the need for enforcing *nix behavior, which is now the default if all other methods fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4578: ARTEMIS-4390 Fix upgrade-linux smoke test on Windows
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4578:
URL: https://github.com/apache/activemq-artemis/pull/4578#issuecomment-1679839749
I'm running the whole CI on this. if it's all good I will merge it tomorrow.
thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jsmucr commented on pull request #4578: ARTEMIS-4390 Fix upgrade-linux smoke test on Windows
Posted by "jsmucr (via GitHub)" <gi...@apache.org>.
jsmucr commented on PR #4578:
URL: https://github.com/apache/activemq-artemis/pull/4578#issuecomment-1679222263
That's not how I usually do things. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jsmucr commented on pull request #4578: ARTEMIS-4390 Fix upgrade-linux smoke test on Windows
Posted by "jsmucr (via GitHub)" <gi...@apache.org>.
jsmucr commented on PR #4578:
URL: https://github.com/apache/activemq-artemis/pull/4578#issuecomment-1679106562
> @jsmucr can you create a JIRA, and amend your commit with the jira ID in the prefix?
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jsmucr commented on pull request #4578: Fix upgrade-linux smoke test on Windows
Posted by "jsmucr (via GitHub)" <gi...@apache.org>.
jsmucr commented on PR #4578:
URL: https://github.com/apache/activemq-artemis/pull/4578#issuecomment-1678522166
@clebertsuconic This is more of a suggestion. I was unable to build Artemis on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4578: NO-JIRA Fix upgrade-linux smoke test on Windows
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4578:
URL: https://github.com/apache/activemq-artemis/pull/4578#issuecomment-1678930807
@jsmucr can you create a JIRA, and amend your commit with the jira ID in the prefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #4578: ARTEMIS-4390 Fix upgrade-linux smoke test on Windows
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic merged PR #4578:
URL: https://github.com/apache/activemq-artemis/pull/4578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4578: ARTEMIS-4390 Fix upgrade-linux smoke test on Windows
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4578:
URL: https://github.com/apache/activemq-artemis/pull/4578#issuecomment-1679114827
I think a much simpler fix would be to just ignore the test if the OS is not Linux, e.g.:
```
Assume.assumeTrue(System.getProperty("os.name").toUpperCase().contains("LINUX");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org