You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by cwe1ss <gi...@git.apache.org> on 2018/03/30 19:39:52 UTC
[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...
GitHub user cwe1ss opened a pull request:
https://github.com/apache/thrift/pull/1524
THRIFT-4535: XML docs; code cleanup (tabs->spaces; String->string)
As discussed in [THRIFT-4535](https://issues.apache.org/jira/browse/THRIFT-4535) we'd like to go back to just one .NET library that supports .NET framework (including Mono) AND .NET Core.
As I had to learn about the library before doing some actual changes, I updated the files to contain proper XML comments (which can be used for IntelliSense) and I did some code cleanup. I did NOT change any code.
Feel free to close this PR, if you prefer to not have such a cleanup commit (for the sake of better git file history).
/cc @Jens-G @jeking3
PS: I'll submit actual code changes once this PR is merged or rejected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cwe1ss/thrift cweiss/csharp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1524
----
commit 3ea256cd578e729759dfcd59698133f0cecc6729
Author: Christian Weiss <ch...@...>
Date: 2018-03-30T19:26:04Z
THRIFT-4535: XML docs; code cleanup (tabs->spaces; String->string)
----
---
[GitHub] thrift issue #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces; Strin...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1524
Squash please.
---
[GitHub] thrift issue #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces; Strin...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1524
Disclaimer: I did not look at every line and I did not look into the AppVeyor failure.
Aside from one minor thing everything that I skimmed through LTGM, and my code still compiles :-) so I'm basically fine with.
---
[GitHub] thrift issue #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces; Strin...
Posted by cwe1ss <gi...@git.apache.org>.
Github user cwe1ss commented on the issue:
https://github.com/apache/thrift/pull/1524
The last AppVeyor failure seems to be unrelated:
>The following tests FAILED:
> 30 - HaskellCabalCheck (Failed)
I fixed the license header in another commit so we'll see if the build succeeds now.
Do you want me to squash the commits or will you do that via Github if you decide to merge the PR?
---
[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...
Posted by cwe1ss <gi...@git.apache.org>.
Github user cwe1ss commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1524#discussion_r178431239
--- Diff: lib/csharp/src/Protocol/TCompactProtocol.cs ---
@@ -7,7 +7,7 @@
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
--- End diff --
This was by accident. I fixed it. thank you!
---
[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1524
---
[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1524#discussion_r178426941
--- Diff: lib/csharp/src/Protocol/TCompactProtocol.cs ---
@@ -7,7 +7,7 @@
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
--- End diff --
Why are we doing that change?
---