You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/08 08:25:35 UTC

[GitHub] [spark] cloud-fan commented on pull request #35760: [SPARK-37865][SQL] Fix union deduplication correctness bug

cloud-fan commented on pull request #35760:
URL: https://github.com/apache/spark/pull/35760#issuecomment-1061524464


   > Result After should be ...
   
   Seems like a typo. Looking at the test, the result is corrected. @karenfeng can you double-check?
   
   > And why we should support select a from (SELECT a, a ...
   
   Yea it's ambiguous but it's already supported before this PR. We can't find a way to fix this without a breaking change so claiming that it selects the first `a` column looks acceptable. Better ideas are welcome!
   
   Note: we can fix this problem more completely at the master branch with a bit of breaking changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org