You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Sammy Nah (Code Review)" <ge...@cloudera.org> on 2023/04/24 18:33:33 UTC

[kudu-CR] [tablet] KUDU-3342 Add an implementation of the block cache on HBW

Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19764

to look at the new patch set (#13).

Change subject: [tablet] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................

[tablet] KUDU-3342 Add an implementation of the block cache on HBW

This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1].  The cache is configured using
a new flag --block_cache_type=HBW.

For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.

The code changes contained are:

* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
  allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
  and test with all three cache types.

[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html

Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 441 insertions(+), 110 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/13
-- 
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 13
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)