[GitHub] [airflow] potiuk commented on issue #13985: Can't save any connection if provider-provided connection form widgets have fields marked as InputRequired

[GitBox <gi...@apache.org>]

potiuk commented on issue #13985:
URL: https://github.com/apache/airflow/issues/13985#issuecomment-770421661


   I do not think 'InputRequired' is used by any built-in connection, that's why it has never been an issue. 
   
   I am not sure if we should implement it or simply disallow InputRequired (also DataRequired and Required I think). We cannot simply delete the field instead of hiding, because this is done dynamically in javascript by selecting connection type and we would have to move it out form/add back if necessary rather than delete.
   
   This however has the potential of breaking the whole connection form by a "rogue" provider that can add such field so we would have to check it when we call the `get_connection_form_widgets()` method.
   
   @ryanahamilton @ashb @kaxil - WDYT? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org