You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by Apache subversion Wiki <co...@subversion.apache.org> on 2015/03/30 19:25:05 UTC

[Subversion Wiki] Update of "Svn19ApiReview" by PhilipMartin

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Subversion Wiki" for change notification.

The "Svn19ApiReview" page has been changed by PhilipMartin:
https://wiki.apache.org/subversion/Svn19ApiReview?action=diff&rev1=14&rev2=15

   * `svn_relpath_limit` — Is this really a good public API, either in functionality or in name? I  suggest it should be a local function in the one file where it's used,  or else made private and named `svn_relpath__first_n_components`.
  
  === svn_fs.h ===
-  * `svn_fs_commit_txn` — Is the `SVN_FS_TXN_CLIENT_DATE` behavior still as described? Do we want to mention here that this is a 1.9 extension?
+  * `svn_fs_commit_txn` — Is the `SVN_FS_TXN_CLIENT_DATE` behavior still as described? Yes. Do we want to mention here that this is a 1.9 extension? SVN_FS_TXN_CLIENT_DATE is marked new in 1.9.
-  * `svn_fs_lock_target_create` — `pool` parameter: Is this a `result_pool` or should it even become 2 pools?
+  * `svn_fs_lock_target_create` — `pool` parameter: Is this a `result_pool` or should it even become 2 pools?Renamed result_pool.
-  * `svn_fs_lock_callback_t` — `pool` parameter: Maybe rename to `scratch_pool`.
+  * `svn_fs_lock_callback_t` — `pool` parameter: Maybe rename to `scratch_pool`. Renamed scratch_pool.
   * `svn_fs_lock_many`, `svn_fs_unlock_many` — Mention in docstring that these are not atomic operations. If the callback returns an error, they simply return that error to their callers and leave part of the locks in their initial and the remainder in the final state. What is the lock error handling in case of `lock_callback==NULL`?
-  * `svn_fs_unlock_many` — What is the `result_pool` being used for?
+  * `svn_fs_unlock_many` — What is the `result_pool` being used for? As for svn_fs_lock_many, it it used to allocate the result data passed to the callback.
  
  === svn_ra_svn.h ===
   * `svn_ra_svn_create_conn4` — The @note is unclear. Is the file being used for time-out detection?